Bug 12045 - Transfer impossible if barcode includes spaces
Summary: Transfer impossible if barcode includes spaces
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-08 14:43 UTC by verolencinas
Modified: 2017-06-14 22:11 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12045 - Transfer impossible if barcode includes spaces (1.15 KB, patch)
2016-01-21 23:51 UTC, Chloe Alabaster
Details | Diff | Splinter Review
Bug 12045 - Transfer impossible if barcode includes spaces (1.43 KB, patch)
2016-01-22 14:17 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 12045 - Transfer impossible if barcode includes spaces (1.48 KB, patch)
2016-01-22 16:12 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description verolencinas 2014-04-08 14:43:09 UTC
Barcodes in Koha can include spaces but if such an item is transferred you get the message "No Item with barcode: nnnn" where nnnn is the barcode with spaces stripped.
Comment 1 Chloe Alabaster 2016-01-21 23:51:09 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-01-22 14:17:41 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2016-01-22 16:12:09 UTC
Created attachment 47195 [details] [review]
Bug 12045 - Transfer impossible if barcode includes spaces

have changed the code which strips the white space to only remove the leading and trailing white space instead

To Test-
1- go to circulation -> transfer
2- attempt to tranfer an item where the barcode has a space in the middle of it
3- it should fail
4- apply patch
5- try again
6- it should work

NOTE: I purposefully added: die "($barcode)";
      Before, all spaces were removed.
          '    white space    ' became '(whitespace)'
      After, only external spaces were remove
          '    white space    ' became '(white space)'

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Brendan Gallagher 2016-01-27 01:09:10 UTC
Pushed to Master - Should be in the May 2016 release. Thanks!
Comment 5 Julian Maurice 2016-01-27 14:36:41 UTC
Patch pushed to 3.22.x, will be in 3.22.3
Comment 6 Frédéric Demians 2016-02-12 06:35:21 UTC
This patch has been pushed to 3.20.x, will be in 3.20.9.