Bug 12060 - Indentation issues allow markup errors in header.inc
Summary: Indentation issues allow markup errors in header.inc
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Mark Tompsett
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-09 18:45 UTC by Mark Tompsett
Modified: 2015-06-04 23:30 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12060 - Indentation issues cause markup errors in header.inc (10.51 KB, patch)
2014-04-09 18:48 UTC, Mark Tompsett
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12060 - Indentation issues cause markup errors in header.inc (10.61 KB, patch)
2014-04-09 19:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12060 - Indentation issues cause markup errors in header.inc (10.77 KB, patch)
2014-04-09 19:55 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 12060 - Indentation issues cause markup errors in header.inc (10.78 KB, patch)
2014-04-09 19:56 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2014-04-09 18:45:48 UTC
By correcting the indentation, it became more apparent the two
markup errors (stray </li> and </div> tags) that were generated
by pasting the page source of
   PROTOCOL://STAFFCLIENT/cgi-bin/koha/tools/holidays.pl
into http://validator.w3.org/check
Comment 1 Mark Tompsett 2014-04-09 18:48:11 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-04-09 18:49:47 UTC
I encountered this while testing bug 12056, so I figured let's tidy it up a little. See the test plan in comment 1.
Comment 3 Owen Leonard 2014-04-09 19:32:53 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-04-09 19:55:27 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-04-09 19:56:45 UTC
Created attachment 26933 [details] [review]
[PASSED QA] Bug 12060 - Indentation issues cause markup errors in header.inc

By correcting the indentation, it became more apparent the two
markup errors (stray </li> and </div> tags) that were generated
by pasting the page source of
   PROTOCOL://STAFFCLIENT/cgi-bin/koha/tools/holidays.pl
into http://validator.w3.org/check

TEST PLAN
---------
1) Home -> Tools -> Calendar in the staff client
2) In another tab open http://validator.w3.org/check
3) Select Validate by Direct Input
4) In the staff client, view the page source
5) Copy the page source to the Validation text box in the
    other tab.
6) Click the 'Check' button.
   -- There will be 3 errors.
7) Apply the patch.
8) Refresh the staff client page.
9) Copy the revised page source into the validation text box.
10) click the 'Check' button.
    -- There will be 1 error.
11) Run the koha qa test tool.

NOTE: This error is not in the intended file to fix.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
git diff --color -w HEAD^ reveals, that only a </li> and a </div>
are removed by this patch, all other changes are whitespace.
Passes all tests and QA script.
Comment 6 Galen Charlton 2014-04-09 22:06:49 UTC
Pushed to master.  Thanks, Mark!
Comment 7 Fridolin Somers 2014-07-25 12:01:55 UTC
Pushed to 3.14.x, will be in 3.14.09