Bug 12065 - Consistent use of encode_qp when sending basket/shelf
Summary: Consistent use of encode_qp when sending basket/shelf
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-10 13:13 UTC by Marcel de Rooy
Modified: 2014-12-07 20:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12065: Consistent use of encode_qp when sending basket/shelf (3.88 KB, patch)
2014-04-10 13:17 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 12065: Consistent use of encode_qp when sending basket/shelf (4.15 KB, patch)
2014-04-21 17:48 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12065: Consistent use of encode_qp when sending basket/shelf (4.24 KB, patch)
2014-04-28 19:34 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12065: Consistent use of encode_qp when sending basket/shelf (4.29 KB, patch)
2014-05-09 13:16 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2014-04-10 13:13:45 UTC

    
Comment 1 Marcel de Rooy 2014-04-10 13:17:08 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2014-04-21 17:48:26 UTC Comment hidden (obsolete)
Comment 3 Bernardo Gonzalez Kriegel 2014-04-28 19:34:11 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2014-05-09 13:16:53 UTC
Created attachment 28131 [details] [review]
[PASSED QA] Bug 12065: Consistent use of encode_qp when sending basket/shelf

QP-encode both mail header and mail body when sending baskets or shelves.
There is no need to Encode qp-encoded strings.
Note that this does not solve all possible encoding problems in the mail
sent. This is related to decoding CGI parameters and use of TT. That problem
is addressed in report 11944.

Test plan:
Verify if sending a basket from opac and staff still works.
Check if sending a shelf (list) from opac and staff still functions as expected.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Cart/List sent form opac/staff works
No koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Galen Charlton 2014-05-09 15:16:08 UTC
Pushed to master.  Thanks, Marcel!