I had a patron account open, viewing some existing restrictions on the patrons account. My session had timed out, and when I clicked the link to remove a restriction I was redirected to an OPAC login page instead of the staff client one.
I confirmed this in master. This was introduced in bug 2720. I don't think it existed in 3.12, since the file doesn't exist in origin/3.12.x. Any patch should also work in 3.14.x, since mod_debarment.pl has not been modified since then. Looks like members/mod_debarment.pl does not pass 'intranet' as the 4th parameter to the checkauth call. Are you doing a patch for this, Owen?
(In reply to M. Tompsett from comment #1) > Are you doing a patch for this, Owen? The fact that the bug is assigned to me and the status is "ASSIGNED" signals my intention to do a patch.
Created attachment 27022 [details] [review] Bug 12069 - If you access members/mod_debarment.pl when logged out you are redirected to OPAC login members/mod_debarment.pl's call to checkauth should pass 'intranet' so that if the user happens to be logged out they will be redirected to the staff client login form. To test, apply the patch and log in to the staff client: - Add a restriction to a patron's account. - View the restrictions tab on the patron's account. You should see the restriction and a "Remove" link for that restriction. - In another tab, log out of the staff client. - In the first tab, click the "Remove" link. You should be redirected to the staff client login page.
Created attachment 27028 [details] [review] [SIGNED OFF] Bug 12069 - If you access members/mod_debarment.pl when logged out you are redirected to OPAC login members/mod_debarment.pl's call to checkauth should pass 'intranet' so that if the user happens to be logged out they will be redirected to the staff client login form. To test, apply the patch and log in to the staff client: - Add a restriction to a patron's account. - View the restrictions tab on the patron's account. You should see the restriction and a "Remove" link for that restriction. - In another tab, log out of the staff client. - In the first tab, click the "Remove" link. You should be redirected to the staff client login page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
This also applies cleanly to 3.14.x
Created attachment 27052 [details] [review] [PASSED QA] Bug 12069 - If you access members/mod_debarment.pl when logged out you are redirected to OPAC login members/mod_debarment.pl's call to checkauth should pass 'intranet' so that if the user happens to be logged out they will be redirected to the staff client login form. To test, apply the patch and log in to the staff client: - Add a restriction to a patron's account. - View the restrictions tab on the patron's account. You should see the restriction and a "Remove" link for that restriction. - In another tab, log out of the staff client. - In the first tab, click the "Remove" link. You should be redirected to the staff client login page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Good catch! Works as described, passes all tests and QA script.
Pushed to master. Thanks, Owen!
Pushed to 3.14.x, will be in 3.14.10