Bug 12081 - tmpl_process3.pl does not delete temp files
Summary: tmpl_process3.pl does not delete temp files
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-14 22:55 UTC by Bernardo Gonzalez Kriegel
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12081 - tmpl_process3.pl - delete temp files (1.90 KB, patch)
2014-04-14 22:58 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12081 - tmpl_process3.pl - delete temp files (2.29 KB, patch)
2014-04-15 16:49 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 12081 - tmpl_process3.pl - delete temp files (2.47 KB, patch)
2014-04-16 11:19 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2014-04-14 22:55:58 UTC
Every time you run translate script it makes temporary files on /tmp
This files are not deleted, and over time it takes a lot of space.
Comment 1 Bernardo Gonzalez Kriegel 2014-04-14 22:58:31 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-04-15 16:49:28 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-04-16 11:19:59 UTC
Created attachment 27166 [details] [review]
Bug 12081 - tmpl_process3.pl - delete temp files

This patch enable deletion of temp files used by
tmpl_process3.pl.
Just removed coments on existing code

To test:
1. Do a count of files on /tmp ( ls /tmp | wc -l )
2. Update preferred language
3. Count again, new files on /tmp
4. Apply the patch
5. Update again, check, no new files

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

NOTE: I watched what temp files were actually in /tmp to make
      sure other processes didn't magically increase/decrease
      the number.
          $ perl translate update {lang code}
      generated 10 temporary files for me (2x5 po files). After
      removing those ten files, and applying the patch, no
      other files were generated.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
These lines has been commented by commit
a399dcefad193fc21ef2dc1fe31d07686ab2da46 without any apparent good
reason.
Comment 4 Jonathan Druart 2014-04-16 11:20:35 UTC
In my opinion, this is a bug, not an enhancement.
Comment 5 Bernardo Gonzalez Kriegel 2014-04-16 12:34:35 UTC
Comment on attachment 27137 [details] [review]
[SIGNED OFF] Bug 12081 - tmpl_process3.pl - delete temp files

Obsolted old patch :)
Comment 6 Galen Charlton 2014-04-16 15:37:10 UTC
Pushed to master.  Thanks, Bernardo!
Comment 7 Fridolin Somers 2014-08-06 09:43:37 UTC
Pushed to 3.14.x, will be in 3.14.10
Comment 8 Kyle M Hall 2014-08-13 14:26:41 UTC
Picked for 3.12.15!