The Greybox javascript library should be moved to intranet-tmpl/lib so that it doesn't have to be duplicated for each translation and so that the translation script won't have to parse it each time.
Created attachment 27265 [details] [review] Bug 12101 - Move Greybox library outside of language-specific directory This patch moves the Greybox library to intranet-tmpl/lib so that it is not duplicated for each set of translated templates. The Greybox library files are called directly only by one include file, greybox.inc, which is modified by this patch. To test, apply the patch and view any page which calls the Greybox library and confirm that modal windows are still generated correctly. For instance, Cataloging -> Cataloging search, click the "Preview MARC" link.
Created attachment 27506 [details] [review] Bug 12101 - Move Greybox library outside of language-specific directory This patch moves the Greybox library to intranet-tmpl/lib so that it is not duplicated for each set of translated templates. The Greybox library files are called directly only by one include file, greybox.inc, which is modified by this patch. To test, apply the patch and view any page which calls the Greybox library and confirm that modal windows are still generated correctly. For instance, Cataloging -> Cataloging search, click the "Preview MARC" link. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described.
Created attachment 27626 [details] [review] [PASSED QA] Bug 12101 - Move Greybox library outside of language-specific directory This patch moves the Greybox library to intranet-tmpl/lib so that it is not duplicated for each set of translated templates. The Greybox library files are called directly only by one include file, greybox.inc, which is modified by this patch. To test, apply the patch and view any page which calls the Greybox library and confirm that modal windows are still generated correctly. For instance, Cataloging -> Cataloging search, click the "Preview MARC" link. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, Owen!