Bug 12111 - Improving templates regarding order notes
Summary: Improving templates regarding order notes
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Mathieu Saby
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 13270
  Show dependency treegraph
 
Reported: 2014-04-19 18:54 UTC by Mathieu Saby
Modified: 2016-01-07 14:16 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
[PATCH] Bug 12111: Improving templates regarding order notes (4.77 KB, patch)
2014-04-19 19:01 UTC, Mathieu Saby
Details | Diff | Splinter Review
[PATCH 2/2] Bug 12111 - QA followup : fix breadcrumbs wording for vendor note (1.41 KB, patch)
2014-04-26 12:42 UTC, Mathieu Saby
Details | Diff | Splinter Review
[PASSED QA] Bug 12111: Improving templates regarding order notes (4.82 KB, patch)
2014-04-26 16:45 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 12111 - QA followup : fix breadcrumbs wording for vendor note (1.49 KB, patch)
2014-04-26 16:45 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 12111: (follow-up) fix breadcrumbs wording for vendor note (1.53 KB, text/plain)
2014-07-09 07:26 UTC, Yohann Dufour
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2014-04-19 18:54:08 UTC

    
Comment 1 Mathieu Saby 2014-04-19 19:01:46 UTC Comment hidden (obsolete)
Comment 2 paxed 2014-04-22 07:50:50 UTC
Small nitpick: "Change order vendor note vendor note" - note the doubled "vendor note"
Comment 3 Mark Tompsett 2014-04-24 01:57:55 UTC
Comment on attachment 27311 [details] [review]
[PATCH] Bug 12111: Improving templates regarding order notes

Review of attachment 27311 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/modordernotes.tt
@@ +1,2 @@
>  [% INCLUDE 'doc-head-open.inc' %]
> +<title>Koha &rsaquo; Acquisition &rsaquo; [% IF (type == "vendor") %]Change order vendor note vendor note[% ELSE %]Change order internal note[% END %]</title>

vendor note vendor note? I think that's wrong. Also, please consider using [%- and -%] as needed to make it more readable and still nicely output, rather than jamming it all onto one line. A minus beside the [% or %] prevents spacing from happening.
Comment 4 Mathieu Saby 2014-04-24 18:24:59 UTC
oups, I wrote it to quickly :(
I'll fix that this week end
Mathieu
Comment 5 Mathieu Saby 2014-04-26 12:42:11 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2014-04-26 16:45:22 UTC
Created attachment 27661 [details] [review]
[PASSED QA] Bug 12111: Improving templates regarding order notes

This bug changes some lines in modordernotes.tt to make them more easily
translatable, especially in german (remark by K. Fisher on bug 9416).
No change should be visible

It also suppresses the ability to edit order "vendor note" in reception, as
the note for vendor is not made to be changed after the document is received.

Test plan :
- in a basket, try to edit the notes (internal and vendor) of order. Check the display is correct
- go in reception module (parcel.pl page) : in the list of all orders to receive,
you must have a link to change "internal note", but no more link to change "vendor note"
- try to receive a specific order which have a "vendor note". On the right panel of the page,
you must have an editable textarea for internal note, and a non-editable (colored in grey) textarea for vendor note

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 7 Katrin Fischer 2014-04-26 16:45:37 UTC
Created attachment 27662 [details] [review]
[PASSED QA] Bug 12111 - QA followup : fix breadcrumbs wording for vendor note

As asked by QAer,
this followup fixes wording in modordernotes.tt for vendor note (Change order vendor note vendor note => Change order vendor note)
It also uses [%- and -%] to make code more readable

Test plan :
try to edit a vendor note, check the wording is correct in breadcrumbs

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, should be nicely translatable now.
Comment 8 Galen Charlton 2014-04-28 15:40:44 UTC
Pushed to master, along with a follow-up that replaces the textarea with a span when displaying the vendor note on the order receiving page.

Thanks, Mathieu!
Comment 9 Mathieu Saby 2014-04-28 19:06:43 UTC
Thank you. I had a doubt between using a span or a textarea, but I saw an other readonly textarea in the template...
Comment 10 Yohann Dufour 2014-07-09 07:26:55 UTC Comment hidden (obsolete)
Comment 11 Yohann Dufour 2014-07-09 07:29:50 UTC
I'm sorry for the last comment, I've done a mistake with git bz
Comment 12 Mason James 2015-02-26 03:32:38 UTC
(In reply to Galen Charlton from comment #8)
> Pushed to master, 

Possible selection for 3.16.x