Tracing of the code reveals that C4::Breeding::ImportBreeding() is not actually used. The last call to it was removed by the patch for bug 10462, which replaced it with calls to GetZ3950BatchId() and AddBiblioToBatch(). The continued existence of the routine has caused a bit of confusion -- see the descriptions of some versions of the patch for bug 11254. The routine should be removed.
Created attachment 27322 [details] [review] Bug 12112: remove disused routine C4::Breeding::ImportBreeding() This patch removes the ImportBreeding() routine, which lost its last caller as of the patch for bug 10462. To test: [1] Verify that prove -v t/Breeding.t passes. [2] Perform a Z39.50 search in the staff interface. [3] Perform a cataloguing reservoir search in the staff inteface; verifying that cached records from the search done in step 2 are retrieved. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 27365 [details] [review] Bug 12112: remove disused routine C4::Breeding::ImportBreeding() This patch removes the ImportBreeding() routine, which lost its last caller as of the patch for bug 10462. To test: [1] Verify that prove -v t/Breeding.t passes. [2] Perform a Z39.50 search in the staff interface. [3] Perform a cataloguing reservoir search in the staff interface; verifying that cached records from the search done in step 2 are retrieved. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 27622 [details] [review] [PASSED QA] Bug 12112: remove disused routine C4::Breeding::ImportBreeding() This patch removes the ImportBreeding() routine, which lost its last caller as of the patch for bug 10462. To test: [1] Verify that prove -v t/Breeding.t passes. [2] Perform a Z39.50 search in the staff interface. [3] Perform a cataloguing reservoir search in the staff interface; verifying that cached records from the search done in step 2 are retrieved. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master.
Pushed to 3.14.x, will be in 3.14.11