Bug 12131 - C4/TmplToken.pm has an unnecessary dependency on Exporter
Summary: C4/TmplToken.pm has an unnecessary dependency on Exporter
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Colin Campbell
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-23 13:21 UTC by Colin Campbell
Modified: 2014-12-07 20:07 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
proposed patch (1.30 KB, patch)
2014-04-23 13:30 UTC, Colin Campbell
Details | Diff | Splinter Review
Bug 12131: Remove unused dependency on Exporter (1.45 KB, patch)
2014-04-24 06:47 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[PASSED QA] Bug 12131: Remove unused dependency on Exporter (1.48 KB, patch)
2014-04-25 11:23 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2014-04-23 13:21:47 UTC
TmplToken has a dependency on Exporter but does not export anything all subroutines being called via a TmplToken object looks like a bit of boilerplate got in the module. Lets remove that and the "burden" of compiling it every time
Comment 1 Colin Campbell 2014-04-23 13:30:00 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2014-04-24 06:47:14 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-04-25 11:23:41 UTC
Created attachment 27608 [details] [review]
[PASSED QA] Bug 12131: Remove unused dependency on Exporter

C4::TmplToken depends on Exporter but does not use any
of its facilities. Removed the dead code so it does not
clog up the source and waste compilation time

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Module still compiles correctly; t/TmplToken.t passes.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Galen Charlton 2014-04-25 15:38:07 UTC
Pushed to master.  Thanks, Colin!