Created attachment 27516 [details] [review] Show guarantees in staff patron details too For some reason, guarantees are not shown in patron details, if the patron is a staffer. Attached patch fixes that.
I think that's because patrons with the staff category are not supposed to have children currently - I think this probably needs more than a display fix. Would also require changing documentation etc. We favor that the staff account should not be identical with the personal account for a staff member, so keep it separate. But there is bug 6922
I think one of the things to check is that you can actually search for a guarantor that is a staff member - if you do it the other way around and create a 'child' first and then link it to the 'adult'.
(In reply to Katrin Fischer from comment #2) > I think one of the things to check is that you can actually search for a > guarantor that is a staff member - if you do it the other way around and > create a 'child' first and then link it to the 'adult'. Yes, you can.
(In reply to Katrin Fischer from comment #1) > I think that's because patrons with the staff category are not supposed to > have children currently - I think this probably needs more than a display > fix. Would also require changing documentation etc. > > We favor that the staff account should not be identical with the personal > account for a staff member, so keep it separate. > > But there is bug 6922 The current behaviour is completely inconsistent: Change a patron's type from adult to staff, and their guarantees aren't showing up in the patron details. If the patron has guarantees, those should be shown, no matter what the patron's type is. If you use separate accounts for staff use and personal use, then your staff account shouldn't have the guarantees. But some other places might not do that kind of separation.
To test: 1) Look at a staffer's detail page. Even if he or she has guarantees, they won't show up there. 2) Install patch 3) Look at a staffer's detail page. If the staffer has guarantees, they will be shown.
This bug has a working patch but has status "NEW". Change status to "Needs signoff".
Created attachment 27772 [details] [review] [Signed-off] Show guarantees for staff patron details too. Staffers are adult borrowers. To test: 1) Look at a staffer's detail page. Even if he or she has guarantees, they won't show up there. 2) Install patch 3) Look at a staffer's detail page. If the staffer has guarantees, they will be shown. http://bugs.koha-community.org/show_bug.cgi?id=12132 Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 28294 [details] [review] [PASSED QA] Show guarantees for staff patron details too. Staffers are adult borrowers. To test: 1) Look at a staffer's detail page. Even if he or she has guarantees, they won't show up there. 2) Install patch 3) Look at a staffer's detail page. If the staffer has guarantees, they will be shown. http://bugs.koha-community.org/show_bug.cgi?id=12132 Followed test plan. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 28475 [details] [review] [COUNTER-PATCH] Bug 12132: display guarantees if a patron has them, regardless of category type If a patron has guarantees, always display them on the patron summary, even if the patron is of a type that ordinarily would have them. For example, at present you can cannot directly add a guarantee to a staff record the way you can do for an adult patron, but if you create a juvenile patron and add a guarantor to it, you can override that restriction. Note that this patch ignores whether that is strictly desirable behavior. To test: [1] Create a juvenile patron. While editing it, make a staff account a guarantor of the new patron. [2] View patron details for the staff account. Note that the juvenile patron is not displayed as a guarantee. [3] Apply this patch. [4] Refresh details for the staff account. The juvenile should now show up. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(In reply to paxed from comment #4) > If the patron has guarantees, those should be shown, no matter what the > patron's type is. That is reasonable. The submitted patch, however, does not actually do this; I have attached a counter-patch that does.
Created attachment 32787 [details] [review] [SIGNED-OFF] Bug 12132: display guarantees if a patron has them, regardless of category type If a patron has guarantees, always display them on the patron summary, even if the patron is of a type that ordinarily would have them. For example, at present you can cannot directly add a guarantee to a staff record the way you can do for an adult patron, but if you create a juvenile patron and add a guarantor to it, you can override that restriction. Note that this patch ignores whether that is strictly desirable behavior. To test: [1] Create a juvenile patron. While editing it, make a staff account a guarantor of the new patron. [2] View patron details for the staff account. Note that the juvenile patron is not displayed as a guarantee. [3] Apply this patch. [4] Refresh details for the staff account. The juvenile should now show up. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Frederic Demians <f.demians@tamil.fr> Galen patch works as described. The way it's implemented seems sensible. Whatever the reason why a patron has guarantes, it make sense to display them. So it's better to check the count of guarantes rather than the current patron type to decide to display guarantes.
Just hope switching bug status directly from In discussion to Signed-off doesn't violate any rule.
Created attachment 32805 [details] [review] [PASSED QA] Bug 12132: display guarantees if a patron has them, regardless of category type If a patron has guarantees, always display them on the patron summary, even if the patron is of a type that ordinarily would have them. For example, at present you can cannot directly add a guarantee to a staff record the way you can do for an adult patron, but if you create a juvenile patron and add a guarantor to it, you can override that restriction. Note that this patch ignores whether that is strictly desirable behavior. To test: [1] Create a juvenile patron. While editing it, make a staff account a guarantor of the new patron. [2] View patron details for the staff account. Note that the juvenile patron is not displayed as a guarantee. [3] Apply this patch. [4] Refresh details for the staff account. The juvenile should now show up. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Frederic Demians <f.demians@tamil.fr> Galen patch works as described. The way it's implemented seems sensible. Whatever the reason why a patron has guarantes, it make sense to display them. So it's better to check the count of guarantes rather than the current patron type to decide to display guarantes. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, small change, no regressions found.
Patch pushed to master. Thanks, Galen!