Bug 12143 - hiding alternate address on patron self registration doesn't hide heading
Summary: hiding alternate address on patron self registration doesn't hide heading
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Jacek Ablewicz
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-25 14:33 UTC by Nicole C. Engard
Modified: 2015-06-04 23:33 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12143 - hiding alternate address on patron self registration doesn't hide heading (3.29 KB, patch)
2014-06-23 10:38 UTC, Jacek Ablewicz
Details | Diff | Splinter Review
Bug 12143 - hiding alternate address on patron self registration doesn't hide heading (3.49 KB, patch)
2014-06-23 12:27 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 12143 - hiding alternate address on patron self registration doesn't hide heading (3.55 KB, patch)
2014-06-24 04:51 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2014-04-25 14:33:33 UTC
In the OPAC when on the self registration form if you have hidden all of the alternate address fields the heading for that section still shows.
Comment 1 Jacek Ablewicz 2014-06-23 10:38:48 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-06-23 12:27:06 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-06-24 04:51:14 UTC
Created attachment 29187 [details] [review]
[PASSED QA] Bug 12143 - hiding alternate address on patron self registration doesn't hide heading

This patch fixes the following issue: in OPAC self registration form,
even if all alternate address fields are configured as hidden,
the heading for "Alternate address" still shows.

To test:

1/ Confirm the issue: hide all alternate adres field names (i.e., enter
B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_phone|
B_email|contactnote into PatronSelfRegistrationBorrowerUnwantedField
system prefrence).
2/ Observe that "Alternate address" section heading still shows
in patron self registration form ("your personal details" tab),
despite that all section fields are configured as hidden.
3/ Apply patch.
4/ Reload OPAC self registration form; confirm that "Alternate address"
is not displyed any longer, and the issue is now fixed.
5/ Remove some field name (e.g. B_address2) from
PatronSelfRegistrationBorrowerUnwantedField; ensure that "Alternate
address" heading does show if at least one section field is not
hidden.
6/ Test steps 1-5 should be performed/repeated in both bootstrap
and prog OPAC themes.

Followed test plan with prog and bootstrap themes, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 4 Chris Cormack 2014-06-26 23:17:39 UTC
Simple typo fix, that fixes a nasty bug. Pushed to Master as MM OPAC .. thanks for the patch Jacek