Bug 12150 - Use more placeholders in translatable javascript strings
Summary: Use more placeholders in translatable javascript strings
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: paxed
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-28 05:53 UTC by paxed
Modified: 2015-06-04 23:33 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Make more translatable javascript strings in intranet use the js string formatter. (18.29 KB, patch)
2014-04-28 05:53 UTC, paxed
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12150 - Use more javascript string formatting in intranet for translated strings. (18.77 KB, patch)
2014-06-09 12:51 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12150 - Use more javascript string formatting in intranet for translated strings. (18.80 KB, patch)
2014-06-11 10:49 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12150: Add missing space and correct innerHTML typo (2.08 KB, patch)
2014-06-11 10:49 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-04-28 05:53:19 UTC Comment hidden (obsolete)
Comment 1 Bernardo Gonzalez Kriegel 2014-05-01 23:19:36 UTC
Is ready to be signed?
Comment 2 paxed 2014-05-05 06:04:40 UTC
(In reply to Bernardo Gonzalez Kriegel from comment #1)
> Is ready to be signed?

Yes, sorry, forgot to change the status.
Comment 3 Owen Leonard 2014-05-06 14:52:44 UTC
This needs a detailed test plan.
Comment 4 Bernardo Gonzalez Kriegel 2014-06-09 12:51:52 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2014-06-11 10:49:23 UTC
Created attachment 28774 [details] [review]
Bug 12150 - Use more javascript string formatting in intranet for translated strings.

http://bugs.koha-community.org/show_bug.cgi?id=12150

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

No bug number on description
No commit message
No test plan
No koha-qa errors

I only signed this because it's useful for translations
but we can live without it, so is up to QA now

Tested some easy messages (e.g. syspref saving), and
updated PO files to check new strings.
Inspected the code, I think that there are no errors.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Jonathan Druart 2014-06-11 10:49:27 UTC
Created attachment 28775 [details] [review]
Bug 12150: Add missing space and correct innerHTML typo

The previous patch forgot to add a space between the string "Edit
action" and the placeholder.

Trying to test it, I found a typo: innerhtml does not exist, it should
be innerHTML.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 7 Jonathan Druart 2014-06-11 10:50:48 UTC
I didn't test everything, but all looks good.

It would be great to have the same kind of patch for the opac bootstrap theme.
Comment 8 Tomás Cohen Arazi 2014-07-03 13:21:13 UTC
No regressions found, patches pushed to master.

Thanks paxed!