Created attachment 27697 [details] [review] Make more translatable javascript strings in intranet use the js string formatter. Make more translatable javascript strings in intranet use the js string formatter. This is continuation from bug 12138, which missed some translatable javascript strings. Also fixes couple untranslatable js strings (in datatables.js), and two translation marker mistakes (in datatables.js and preferences.js)
Is ready to be signed?
(In reply to Bernardo Gonzalez Kriegel from comment #1) > Is ready to be signed? Yes, sorry, forgot to change the status.
This needs a detailed test plan.
Created attachment 28733 [details] [review] [SIGNED-OFF] Bug 12150 - Use more javascript string formatting in intranet for translated strings. http://bugs.koha-community.org/show_bug.cgi?id=12150 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No bug number on description No commit message No test plan No koha-qa errors I only signed this because it's useful for translations but we can live without it, so is up to QA now Tested some easy messages (e.g. syspref saving), and updated PO files to check new strings. Inspected the code, I think that there are no errors.
Created attachment 28774 [details] [review] Bug 12150 - Use more javascript string formatting in intranet for translated strings. http://bugs.koha-community.org/show_bug.cgi?id=12150 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No bug number on description No commit message No test plan No koha-qa errors I only signed this because it's useful for translations but we can live without it, so is up to QA now Tested some easy messages (e.g. syspref saving), and updated PO files to check new strings. Inspected the code, I think that there are no errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 28775 [details] [review] Bug 12150: Add missing space and correct innerHTML typo The previous patch forgot to add a space between the string "Edit action" and the placeholder. Trying to test it, I found a typo: innerhtml does not exist, it should be innerHTML. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I didn't test everything, but all looks good. It would be great to have the same kind of patch for the opac bootstrap theme.
No regressions found, patches pushed to master. Thanks paxed!