Bug 12161 - Serials receiving is broken
Summary: Serials receiving is broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low critical (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 12138
Blocks: 7677
  Show dependency treegraph
 
Reported: 2014-04-29 12:22 UTC by Matthias Meusburger
Modified: 2019-06-27 09:24 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (1.30 KB, patch)
2014-04-29 12:25 UTC, Matthias Meusburger
Details | Diff | Splinter Review
Fix bug introduced in bug 12138, javascript formatting (1.36 KB, patch)
2014-04-30 04:45 UTC, paxed
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Meusburger 2014-04-29 12:22:10 UTC
Bug 12138 (Use placeholders in translatable javascript strings) broke javascript interpretation in serials-edit.tt, making serial receiving impossible when "create an item record when receiving this serial" is used for the subscription.
Comment 1 Matthias Meusburger 2014-04-29 12:25:08 UTC Comment hidden (obsolete)
Comment 2 paxed 2014-04-30 04:45:03 UTC
Created attachment 27793 [details] [review]
Fix bug introduced in bug 12138, javascript formatting

Definitely my fault. Signed off that patch.
Comment 3 Bernardo Gonzalez Kriegel 2014-05-01 19:21:27 UTC
(In reply to paxed from comment #2)
> Created attachment 27793 [details] [review] [review]
> Fix bug introduced in bug 12138, javascript formatting
> 
> Definitely my fault. Signed off that patch.

But forgot to change status :)
Comment 4 Galen Charlton 2014-05-06 14:44:58 UTC
Given the seriousness of this, I've taken the liberty of pushing it to master right away.
Comment 5 Galen Charlton 2014-05-06 14:45:18 UTC
Thanks, Matthias!