Bug 12185 - Remove extra "f" from parcel.tt
Summary: Remove extra "f" from parcel.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Magnus Enger
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-05 08:42 UTC by Magnus Enger
Modified: 2014-12-07 20:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 12185 - Remove extra "f" from parcel.tt (1.86 KB, patch)
2014-05-05 08:46 UTC, Magnus Enger 		Details | Diff | Splinter Review
Bug 12185 - Remove extra "f" from parcel.tt (1.92 KB, patch)
2014-05-06 09:51 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 12185 - Remove extra "f" from parcel.tt (1.98 KB, patch)
2014-05-06 09:53 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2014-05-05 08:42:32 UTC 
Pasi Kallinen spotted this rather obvious typo in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt:

                 [% IF ( loop_order.order_internalnote ) %]
                    f<p class="ordernote"><strong>Internal note: </strong>[% loop_order.order_internalnote|html %] [<a href="/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=[% loop_order.ordernumber %]&amp;referrer=/cgi-bin/koha/acqui/parcel.pl%3Finvoiceid=[% invoiceid %]&type=internal">Change internal note</a>]</p>
                [% ELSE %]

The "f" before the "<p" should not be there. Patch coming in a sec.
Comment 1 Magnus Enger 2014-05-05 08:46:04 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2014-05-06 04:40:57 UTC 
Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com>
Comment 3 Jonathan Druart 2014-05-06 09:51:00 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-05-06 09:51:21 UTC 
I added the signoff manually. It seems something went wrong on signing off from the sandbox.
Comment 5 Jonathan Druart 2014-05-06 09:51:46 UTC 
[OFF] the cronjob crashed:
Warning: commit message does not conform to UTF-8.
You may want to amend it after fixing the message, or set the config
variable i18n.commitencoding to the encoding your project uses.
Failed to attach patch to bug 12185, status=200
Comment 6 Jonathan Druart 2014-05-06 09:53:20 UTC 
Created attachment 27968 [details] [review]
Bug 12185 - Remove extra "f" from parcel.tt

There is a typoed "f" outside of the HTML on line 279 of
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
This patch removes that extra "f".

To test:
It should be sufficient to look at line 279 before and after the
patch has been applied.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 7 Galen Charlton 2014-05-06 14:40:06 UTC 
Pushed to master.  Thanks, Magnus!

(I know it's a string change, but since it's a tiny one, I'm pushing it now).