We have 2 tabs that have only one preference on them - Tools & Creators I think that since Creators is used by the Patron Cards tool the preference there should be moved to Tools and the Creator's tab removed. Nicole
Created attachment 27999 [details] [review] Bug 12190: fold the "Creators" system preference tab into "Tools" The "Creators" tab in the system preferences editor had only one preference. In order to consolidate the display as well as to address the issue that "creators" doesn't have much of a connection to "patron cards", the ImageLimit system preference is moved to the Tools tab by this patch. To test: [1] Verify that the ImageLimit preference now shows up in the Tools tab in the system preference editor (along with an existing Tools preference, MaxItemsForBatch. [2] Verify that the sysprefs editor no longer has a "Creators" tab. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 28446 [details] [review] Bug 12190: fold the "Creators" system preference tab into "Tools" The "Creators" tab in the system preferences editor had only one preference. In order to consolidate the display as well as to address the issue that "creators" doesn't have much of a connection to "patron cards", the ImageLimit system preference is moved to the Tools tab by this patch. To test: [1] Verify that the ImageLimit preference now shows up in the Tools tab in the system preference editor (along with an existing Tools preference, MaxItemsForBatch. [2] Verify that the sysprefs editor no longer has a "Creators" tab. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 28459 [details] [review] [PASSED QA] Bug 12190: fold the "Creators" system preference tab into "Tools" The "Creators" tab in the system preferences editor had only one preference. In order to consolidate the display as well as to address the issue that "creators" doesn't have much of a connection to "patron cards", the ImageLimit system preference is moved to the Tools tab by this patch. To test: [1] Verify that the ImageLimit preference now shows up in the Tools tab in the system preference editor (along with an existing Tools preference, MaxItemsForBatch. [2] Verify that the sysprefs editor no longer has a "Creators" tab. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master.
This says 'pushed to master' the day after the 3.16 release, so does that mean it will be in 3.18? I'm confused because Galen is the one who pushed it :) Asking for the manual.
Hi Nicole, the patch included a string change and I think was therefore held back until after the 3.16 release. It's not in 3.16.0.
Thanks!! I'll save it for the 3.18 manual. Nicole