Bug 12205 - It should be possible for Holds charges to count towards blocking checkout
Summary: It should be possible for Holds charges to count towards blocking checkout
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-07 01:36 UTC by Chris Cormack
Modified: 2015-06-04 23:33 UTC (History)
6 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12205 : Add a system preference allowing hold charges to block circ (3.19 KB, patch)
2014-05-07 02:14 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 12205 : Add a system preference allowing hold charges to block circ (3.21 KB, patch)
2014-06-11 02:53 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 12205 : Add a system preference allowing hold charges to block circ (3.31 KB, patch)
2014-06-11 10:11 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12205: (regression tests) HoldsInNoissuesCharge controls GetMemberAccountBalance behaviour regarding hold charges (2.51 KB, patch)
2014-09-02 13:41 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2014-05-07 01:36:09 UTC
There are currently 2 systempreferences, which are used to determine what charges are counted towards blocking circulation

RentalsInNoissueCharge
and
ManInvInNoissuesCharge

Which means that someone may have 10000 in charges for holds, and still be able to checkout just fine. There needs to be a systempreference for this also
Comment 1 Chris Cormack 2014-05-07 02:14:04 UTC Comment hidden (obsolete)
Comment 2 Christopher Brannon 2014-06-04 20:48:42 UTC
Chris,
I would love to test this, but unfortunately, I have no idea what a hold charge is.  Could you help me in this?  How does one set hold charges?  Obviously this is not something we've touched on our system.

Christopher
Comment 3 Christopher Brannon 2014-06-04 20:53:48 UTC
Chris,
Never mind.  I see the fee setting.  I didn't realize we could charge for holds.  Interesting.

Christopher
Comment 4 Chris Cormack 2014-06-04 21:15:59 UTC
(In reply to Christopher Brannon from comment #3)
> Chris,
> Never mind.  I see the fee setting.  I didn't realize we could charge for
> holds.  Interesting.
> 
> Christopher

You can pretty much do everthing.

Theres a quote on IRC 

"rangi: #thingsihavelearnt if there is a mad scheme a library somewhere will be doing it ... except madder" (added by wizzyrea at 09:20 PM, March 30, 2011)
Comment 5 Christopher Brannon 2014-06-04 21:23:53 UTC
Chris,
Either I am missing either missing a step or a cron job.  I'm trying to test on a sandbox but no charges appear with or without the patch.  Got any ideas?

Christopher
Comment 6 Chris Cormack 2014-06-04 21:25:28 UTC
You've set the charge on the borrowers category eh?

And placed a hold? There is no cron job needed, you should be able to see the charge in the fines screen with or without the patch. It only doesn't show on the circ screen (without the patch)
Comment 7 Chris Cormack 2014-06-04 21:26:17 UTC
It also might be related to the item being out, so maybe try placing a hold on one that is available, and one that is onloan too. 

Thanks for testing
Comment 8 Christopher Brannon 2014-06-04 21:56:47 UTC
As far as I can see, I've set it right.  I notice you are calling it borrower category, but I am seeing it as patron category.

http://screencast.com/t/s0A6mWCZZge

I'm stumped on this one.  I've tried placing a next available hold, placed item level hold on item that is in, and item level hold on item checked out.  I set a 0.50 hold charge for PT patrons, and use the Henry Acevedo (23529000035676) account, set as PT patron.

You are welcome to take a look.  (Sandbox 8)  Not sure why it isn't charging at all.

Christopher
Comment 9 Nick Clemens 2014-06-11 02:50:48 UTC
I tested on Sandbox 1 and had good results though I could only get 1 item to charge for a hold, but I suspect that is more about my understanding of holds charges since I have never used them before.

I also had a hard time figuring out why charges weren't showing up on the checkout screen until it occurred to me that the obvious step of turning in the system preference would help.
Comment 10 Biblibre Sandboxes 2014-06-11 02:52:48 UTC
Patch tested with a sandbox, by Nick Clemens <nick@quecheelibrary.org>
Comment 11 Biblibre Sandboxes 2014-06-11 02:53:07 UTC Comment hidden (obsolete)
Comment 12 Jonathan Druart 2014-06-11 10:11:07 UTC
Created attachment 28772 [details] [review]
Bug 12205 : Add a system preference allowing hold charges to block circ

Currently, if you have holds charges, they are not taken into
consideration when circulating items.

Manual Invoices, and rental charges are governed by a systempreference

Holds are never counted

And all other charges (overdues, lost items etc) are counted

This patch adds a systempreference to allow Hold charges to be counted
as well.

To test

1/ Set a borrower category to have holds charges
2/ Place a hold for a borrower in that category
3/ Go to checkout, notice that charge is not showing or blocking on
that screen
4/ apply patch
5/ notice that charge now shows on checkout

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 13 Tomás Cohen Arazi 2014-09-02 13:41:25 UTC
Created attachment 31321 [details] [review]
Bug 12205: (regression tests) HoldsInNoissuesCharge controls GetMemberAccountBalance behaviour regarding hold charges

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Comment 14 Tomás Cohen Arazi 2014-09-02 13:44:31 UTC
Patch pushed to master.

Thanks Chris!