Bug 12211 - Wrong home link in bootstrap opac-auth
Summary: Wrong home link in bootstrap opac-auth
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/opac-user.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-07 15:58 UTC by Fridolin Somers
Modified: 2016-06-21 21:36 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12211 - Wrong home link in bootstrap opac-auth (1.22 KB, patch)
2014-05-07 16:00 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 12211 - Wrong home link in bootstrap opac-auth (1.29 KB, patch)
2014-05-19 15:00 UTC, Fridolin Somers
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12211 - Wrong home link in bootstrap opac-auth (1.39 KB, patch)
2014-05-19 19:21 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12211 - Wrong home link in bootstrap opac-auth (1.47 KB, patch)
2014-05-21 10:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2014-05-07 15:58:15 UTC
In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads to #, it should lead to opac-main.pl like in all other pages.
Comment 1 Fridolin Somers 2014-05-07 16:00:45 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-05-17 00:56:40 UTC
This template file is called from Auth.pm, 
try a fake (opac) login and you will end with this page.

Patch is ok, but to really look like the others, it needs to go from this

<li><a href="#">Home</a> <span class="divider">&rsaquo;</span></li>
<li>Log in</li>

to this

<li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">&rsaquo;</span></li>
<li><a href="#">Log in</a></li>
Comment 3 Fridolin Somers 2014-05-19 15:00:33 UTC Comment hidden (obsolete)
Comment 4 Fridolin Somers 2014-05-19 15:01:30 UTC
(In reply to Bernardo Gonzalez Kriegel from comment #2)
Here is new patch
Comment 5 Mark Tompsett 2014-05-19 15:32:21 UTC
Comment on attachment 28332 [details] [review]
Bug 12211 - Wrong home link in bootstrap opac-auth

Review of attachment 28332 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
@@ +14,5 @@
>  
>  <div class="main">
>      <ul class="breadcrumb">
> +        <li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">&rsaquo;</span></li>
> +        <li><a href="#">Log in</a></li>

Is there a reason you added the href? The title says wrong home link. It says nothing about missing a link on "Log in".
Comment 6 Bernardo Gonzalez Kriegel 2014-05-19 19:21:53 UTC Comment hidden (obsolete)
Comment 7 Bernardo Gonzalez Kriegel 2014-05-19 19:28:45 UTC
(In reply to M. Tompsett from comment #5)
> Comment on attachment 28332 [details] [review] [review]
> 
> Is there a reason you added the href? The title says wrong home link. It
> says nothing about missing a link on "Log in".

Just consistency :)
Comment 8 Katrin Fischer 2014-05-21 10:40:02 UTC
Created attachment 28398 [details] [review]
[PASSED QA] Bug 12211 - Wrong home link in bootstrap opac-auth

In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads to #, it should lead to opac-main.pl like in all other pages.

Test plan :
 - Use boostrap opac theme
 - Go to cgi-bin/koha/opac-user.pl when not logged
=> without patch, clicking on Home does not change the page
=> with patch, clicking on Home leads to opac-main.pl

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Link ok, no errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described.
Comment 9 Galen Charlton 2014-05-22 21:17:04 UTC
Pushed to master and 3.16.x.  Thanks, Fridolin!
Comment 10 Fridolin Somers 2014-12-08 13:31:43 UTC
Pushed to 3.14.x, will be in 3.14.12.