Bug 12229 - tools/export.pl fix to forbid adding of invalid records
Summary: tools/export.pl fix to forbid adding of invalid records
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P3 critical (vote)
Assignee: Stéphane Delaune
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 13082
  Show dependency treegraph
 
Reported: 2014-05-12 07:37 UTC by Stéphane Delaune
Modified: 2019-06-27 09:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch : fix to prevent adding of invalid records in marc file (1023 bytes, patch)
2014-05-12 15:02 UTC, Stéphane Delaune
Details | Diff | Splinter Review
[SIGNED-oFF] Bug 12229: fix to prevent adding of invalid records in marc file (1.34 KB, patch)
2014-05-21 19:48 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12229: fix to prevent adding of invalid records in marc file (1.41 KB, patch)
2014-05-23 10:58 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Delaune 2014-05-12 07:37:24 UTC
tools/export.pl it is able to add truncated or invalid records into the output iso2709 file, without error message. So if we want to read generated iso2709 file : script die
Comment 1 Stéphane Delaune 2014-05-12 15:02:36 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-05-21 19:48:43 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-05-23 10:58:07 UTC
Created attachment 28456 [details] [review]
[PASSED QA] Bug 12229: fix to prevent adding of invalid records in marc file

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described. No errors

Test:
1. Edit record, add 100.000 chars text to 500a
2. xml export produce the record,
3. mrc export do not produce the record,
warning on log
export.pl: record (number 2025) length 102668 is larger than the MARC spec allows (99999 bytes) at...

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Galen Charlton 2014-05-23 15:37:59 UTC
Pushed to master and 3.16.x.  Thanks, Stéphane!
Comment 5 Fridolin Somers 2014-10-16 10:31:08 UTC
Pushed to 3.14.x, will be in 3.14.12