I don't know exactly why C4::Templates::_current_language() was needed, but I think it is not needed anymore, since C4::Languages::getlanguage() returns the correct language in XSLTParse4Display.
Created attachment 28201 [details] [review] Bug 12237: Remove the "horrible hack" in C4::Templates Use C4::Languages::getlanguage() instead of C4::Templates::_current_language() Test plan: 1/ Set one of the 4 XSLT sysprefs to 'default' 2/ Go to the corresponding page 3/ Switch language and check that the right XSLT is used 4/ Set the same syspref to something with '{langcode}' in it. For example: "../koha-tmpl/opac-tmpl/bootstrap/{langcode}/xslt/UNIMARCslim2OPACDetail.xsl" 5/ Go back to the corresponding page 6/ Switch language and check that the right XSLT is used 7/ Change a compact.xsl for a language (for example koha-tmpl/intranet-tmpl/prog/fr-FR/xslt/compact.xsl) to be able to see differences 8/ Go to a biblio detail page in staff interface and click on "MARC Preview: Show" 9/ Close the popup, switch language and click again on the same link 10/ Check that the correct XSLT is used.
Created attachment 29331 [details] [review] [SIGNED-OFF] Bug 12237: Remove the "horrible hack" in C4::Templates Use C4::Languages::getlanguage() instead of C4::Templates::_current_language() Test plan: 1/ Set one of the 4 XSLT sysprefs to 'default' 2/ Go to the corresponding page 3/ Switch language and check that the right XSLT is used 4/ Set the same syspref to something with '{langcode}' in it. For example: "../koha-tmpl/opac-tmpl/bootstrap/{langcode}/xslt/UNIMARCslim2OPACDetail.xsl" 5/ Go back to the corresponding page 6/ Switch language and check that the right XSLT is used 7/ Change a compact.xsl for a language (for example koha-tmpl/intranet-tmpl/prog/fr-FR/xslt/compact.xsl) to be able to see differences 8/ Go to a biblio detail page in staff interface and click on "MARC Preview: Show" 9/ Close the popup, switch language and click again on the same link 10/ Check that the correct XSLT is used. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described following test plan. No koha-qa errors
Created attachment 29339 [details] [review] [PASSED QA] Bug 12237: Remove the "horrible hack" in C4::Templates Use C4::Languages::getlanguage() instead of C4::Templates::_current_language() Test plan: 1/ Set one of the 4 XSLT sysprefs to 'default' 2/ Go to the corresponding page 3/ Switch language and check that the right XSLT is used 4/ Set the same syspref to something with '{langcode}' in it. For example: "../koha-tmpl/opac-tmpl/bootstrap/{langcode}/xslt/UNIMARCslim2OPACDetail.xsl" 5/ Go back to the corresponding page 6/ Switch language and check that the right XSLT is used 7/ Change a compact.xsl for a language (for example koha-tmpl/intranet-tmpl/prog/fr-FR/xslt/compact.xsl) to be able to see differences 8/ Go to a biblio detail page in staff interface and click on "MARC Preview: Show" 9/ Close the popup, switch language and click again on the same link 10/ Check that the correct XSLT is used. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described following test plan. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> No problems found, passes tests and QA script.
Patch pushed to master. Thanks Julian!