Bug 12237 - Remove the "horrible hack" in C4::Templates
Summary: Remove the "horrible hack" in C4::Templates
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-13 08:40 UTC by Julian Maurice
Modified: 2015-06-04 23:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12237: Remove the "horrible hack" in C4::Templates (3.93 KB, patch)
2014-05-13 08:40 UTC, Julian Maurice
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12237: Remove the "horrible hack" in C4::Templates (4.06 KB, patch)
2014-06-27 14:34 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12237: Remove the "horrible hack" in C4::Templates (4.15 KB, patch)
2014-06-28 10:06 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2014-05-13 08:40:00 UTC
I don't know exactly why C4::Templates::_current_language() was needed, but I think it is not needed anymore, since C4::Languages::getlanguage() returns the correct language in XSLTParse4Display.
Comment 1 Julian Maurice 2014-05-13 08:40:25 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-06-27 14:34:57 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-06-28 10:06:32 UTC
Created attachment 29339 [details] [review]
[PASSED QA] Bug 12237: Remove the "horrible hack" in C4::Templates

Use C4::Languages::getlanguage() instead of
C4::Templates::_current_language()

Test plan:
1/ Set one of the 4 XSLT sysprefs to 'default'
2/ Go to the corresponding page
3/ Switch language and check that the right XSLT is used
4/ Set the same syspref to something with '{langcode}' in it. For
example:
"../koha-tmpl/opac-tmpl/bootstrap/{langcode}/xslt/UNIMARCslim2OPACDetail.xsl"
5/ Go back to the corresponding page
6/ Switch language and check that the right XSLT is used
7/ Change a compact.xsl for a language (for example
koha-tmpl/intranet-tmpl/prog/fr-FR/xslt/compact.xsl) to be able to see
differences
8/ Go to a biblio detail page in staff interface and click on "MARC
Preview: Show"
9/ Close the popup, switch language and click again on the same link
10/ Check that the correct XSLT is used.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works as described following test plan.
No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
No problems found, passes tests and QA script.
Comment 4 Tomás Cohen Arazi 2014-07-03 13:41:26 UTC
Patch pushed to master.

Thanks Julian!