On bug 10845 some lines from sample_notices.sql were ommited when adding the trailing parameter. This produces some errors when installing using 'es-ES' sample data; and, in some conditions I couldn't reproduce right now, ocasional C4/NewsChannel.pm errors due to mandatory message transport data incompletely loaded. To reproduce: - Make sure your setup has the es-ES translations installed and up-to-date (translation should raise lots of warnings) - With a cleaned (DROP DATABASE ... ; CREATE DATABASE ...;) run the webinstaller - Choose es-ES for the webinstaller. - Follow the steps and choose all the sample data. => Errors related to sample_notices.sql and sample_notices_message_transports.sql show.
Created attachment 28218 [details] [review] Bug 12251: Error in sample_notices.sql (es-ES) On bug 10845 some lines from sample_notices.sql were ommited when adding the trailing parameter. This produces some errors when installing using 'es-ES' sample data; and, in some conditions I couldn't reproduce right now, ocasional C4/NewsChannel.pm errors due to mandatory message transport data incompletely loaded. To reproduce: - Make sure your setup has the es-ES translations installed and up-to-date (translation should raise lots of warnings) - With a cleaned (DROP DATABASE ... ; CREATE DATABASE ...;) run the webinstaller - Choose es-ES for the webinstaller. - Follow the steps and choose all the sample data. => Errors related to sample_notices.sql and sample_notices_message_transports.sql show. To fix: - Apply this patch. - Reset your DB (DROP DATABASE, CREATE DATABASE -- whatever method you prefer) - Run the webinstaller using es-ES - Follow the steps and choose all sample data. => SUCCESS: no errors. - Sign :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba
Created attachment 28230 [details] [review] Bug 12251: Error in sample_notices.sql (es-ES) On bug 10845 some lines from sample_notices.sql were ommited when adding the trailing parameter. This produces some errors when installing using 'es-ES' sample data; and, in some conditions I couldn't reproduce right now, ocasional C4/NewsChannel.pm errors due to mandatory message transport data incompletely loaded. To reproduce: - Make sure your setup has the es-ES translations installed and up-to-date (translation should raise lots of warnings) - With a cleaned (DROP DATABASE ... ; CREATE DATABASE ...;) run the webinstaller - Choose es-ES for the webinstaller. - Follow the steps and choose all the sample data. => Errors related to sample_notices.sql and sample_notices_message_transports.sql show. To fix: - Apply this patch. - Reset your DB (DROP DATABASE, CREATE DATABASE -- whatever method you prefer) - Run the webinstaller using es-ES - Follow the steps and choose all sample data. => SUCCESS: no errors. - Sign :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 28231 [details] [review] Bug 12251: Error in sample_notices.sql (fr-FR) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 28232 [details] [review] Bug 12251: Error in sample_notices.sql (ru-RU) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
(In reply to Tomás Cohen Arazi from comment #0) > On bug 10845 some lines from sample_notices.sql were ommited when adding the > trailing parameter. This produces some errors when installing using 'es-ES' > sample data And fr-FR and ru-RU. Sorry for that! I change the severity, it is critical (blocker?) for 3.16.
Actually, it was a "Passed QA", I forgot to update the status.
(In reply to Jonathan Druart from comment #6) > Actually, it was a "Passed QA", I forgot to update the status. Of course, Galen, if you don't see any objection. I inserted the 3 modified files into an empty table and no error appeared.
Pushed to master. Thanks, Tomás and Jonathan!