Bug 12251 - Error in sample_notices.sql (es-ES)
Summary: Error in sample_notices.sql (es-ES)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low blocker (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on: 10845
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-13 21:50 UTC by Tomás Cohen Arazi
Modified: 2019-06-27 09:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12251: Error in sample_notices.sql (es-ES) (8.01 KB, patch)
2014-05-13 21:56 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 12251: Error in sample_notices.sql (es-ES) (8.07 KB, patch)
2014-05-14 07:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12251: Error in sample_notices.sql (fr-FR) (2.69 KB, patch)
2014-05-14 07:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12251: Error in sample_notices.sql (ru-RU) (2.51 KB, patch)
2014-05-14 07:13 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2014-05-13 21:50:09 UTC
On bug 10845 some lines from sample_notices.sql were ommited when adding the trailing parameter. This produces some errors when installing using 'es-ES' sample data; and, in some conditions I couldn't reproduce right now, ocasional C4/NewsChannel.pm errors due to mandatory message transport data incompletely loaded.

To reproduce:
- Make sure your setup has the es-ES translations installed and up-to-date (translation should raise lots of warnings)
- With a cleaned (DROP DATABASE ... ; CREATE DATABASE ...;) run the webinstaller
- Choose es-ES for the webinstaller.
- Follow the steps and choose all the sample data.
=> Errors related to sample_notices.sql and sample_notices_message_transports.sql show.
Comment 1 Tomás Cohen Arazi 2014-05-13 21:56:58 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-05-14 07:13:02 UTC
Created attachment 28230 [details] [review]
Bug 12251: Error in sample_notices.sql (es-ES)

On bug 10845 some lines from sample_notices.sql were ommited when adding the trailing parameter. This produces some errors when installing using 'es-ES' sample data; and, in some conditions I couldn't reproduce right now, ocasional C4/NewsChannel.pm errors due to mandatory message transport data incompletely loaded.

To reproduce:
- Make sure your setup has the es-ES translations installed and up-to-date (translation should raise lots of warnings)
- With a cleaned (DROP DATABASE ... ; CREATE DATABASE ...;) run the webinstaller
- Choose es-ES for the webinstaller.
- Follow the steps and choose all the sample data.
=> Errors related to sample_notices.sql and sample_notices_message_transports.sql show.

To fix:
- Apply this patch.
- Reset your DB (DROP DATABASE, CREATE DATABASE -- whatever method you prefer)
- Run the webinstaller using es-ES
- Follow the steps and choose all sample data.
=> SUCCESS: no errors.
- Sign :-D

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 3 Jonathan Druart 2014-05-14 07:13:13 UTC
Created attachment 28231 [details] [review]
Bug 12251: Error in sample_notices.sql (fr-FR)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Jonathan Druart 2014-05-14 07:13:17 UTC
Created attachment 28232 [details] [review]
Bug 12251: Error in sample_notices.sql (ru-RU)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jonathan Druart 2014-05-14 07:14:46 UTC
(In reply to Tomás Cohen Arazi from comment #0)
> On bug 10845 some lines from sample_notices.sql were ommited when adding the
> trailing parameter. This produces some errors when installing using 'es-ES'
> sample data

And fr-FR and ru-RU. Sorry for that!
I change the severity, it is critical (blocker?) for 3.16.
Comment 6 Jonathan Druart 2014-05-15 11:14:07 UTC
Actually, it was a "Passed QA", I forgot to update the status.
Comment 7 Jonathan Druart 2014-05-15 11:18:08 UTC
(In reply to Jonathan Druart from comment #6)
> Actually, it was a "Passed QA", I forgot to update the status.

Of course, Galen, if you don't see any objection.

I inserted the 3 modified files into an empty table and no error appeared.
Comment 8 Galen Charlton 2014-05-16 02:56:16 UTC
Pushed to master.  Thanks, Tomás and Jonathan!