t/db_dependent/Items.t has these lines: 172 $schema->resultset('Systempreference')->update_or_create({ variable => 'item-level_itypes', value => 0 }); 173 ok( $item->effective_itemtype() eq 'BIB_LEVEL', '$item->itemtype() returns biblioitem.itemtype when item-level_itypes is disabled' ); 174 175 $schema->resultset('Systempreference')->update_or_create({ variable => 'item-level_itypes', value => 1 }); 176 ok( $item->effective_itemtype() eq 'ITEM_LEVEL', '$item->itemtype() returns items.itype when item-level_itypes is disabled' ); I believe the last line should be "...when item-level_itypes is enabled". No practical impact, but it might be confusing to someone at some time.
Created attachment 33397 [details] [review] Bug 12264: Correct tiny typo in t/db_dependent/Items.t One of the tests claims 'item-level_itypes is disabled' when it should be 'item-level_itypes is enabled'. Patch fixes this. To test: - run t/db_dependent/Items.t - tests should all pass - verify the last test reads 'enabled' - look at the code and see it's true
Created attachment 33405 [details] [review] Bug 12264: Correct tiny typo in t/db_dependent/Items.t One of the tests claims 'item-level_itypes is disabled' when it should be 'item-level_itypes is enabled'. Patch fixes this. To test: - run t/db_dependent/Items.t - tests should all pass - verify the last test reads 'enabled' - look at the code and see it's true Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 33408 [details] [review] Bug 12264: Correct tiny typo in t/db_dependent/Items.t One of the tests claims 'item-level_itypes is disabled' when it should be 'item-level_itypes is enabled'. Patch fixes this. To test: - run t/db_dependent/Items.t - tests should all pass - verify the last test reads 'enabled' - look at the code and see it's true Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 33409 [details] [review] Bug 12264: [QA Follow-up] Fixing biblionumber/biblioitemnumber mixup While testing the string change on 12264, I had this result: DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at /usr/share/koha/testclone/C4/Items.pm line 2191. DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at /usr/share/koha/testclone/C4/Items.pm line 2191. # Child (GetItemsInfo tests) exited without calling finalize() not ok 4 - GetItemsInfo tests This was caused by this line in the unit test: my $biblionumber = get_biblio(); This routine returns: return ($bibnum, $bibitemnum); So instead of the bibnum the bibitemnum is saved in biblionumber. In my test database bibnum and bibitemnum somehow got out of sync, revealing this bug :) The fix is just adding parentheses: my ( $biblionumber ) = get_biblio(); Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Patches pushed to master. Thanks Katrin and Marcel!