Bug 12271 - valid-templates.t does not test bootstrap opac templates
Summary: valid-templates.t does not test bootstrap opac templates
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low critical (vote)
Assignee: Fridolin Somers
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-16 09:25 UTC by Fridolin Somers
Modified: 2019-06-27 09:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12271 - valid-templates.t does not test bootstrap opac templates (2.47 KB, patch)
2014-05-16 09:31 UTC, Fridolin Somers
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12271 - valid-templates.t does not test bootstrap opac templates (2.63 KB, patch)
2014-05-16 23:44 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2014-05-16 09:25:01 UTC
valid-templates.t actually tests the templates and includes of only the "prog" theme at opac and intranet.
It does not test the opac templates and includes of bootstrap theme, nor ccsr.

This is critical since this test is used for patch integrations in release maintenance.
Comment 1 Fridolin Somers 2014-05-16 09:31:58 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-05-16 23:44:45 UTC
Created attachment 28298 [details] [review]
[SIGNED-OFF] Bug 12271 - valid-templates.t does not test bootstrap opac templates

valid-templates.t actually tests the templates and includes of only the "prog" theme at opac and intranet.
It does not test the opac templates and includes of bootstrap theme, nor ccsr.
This is critical since this test is used for patch integrations in release maintenance.

This patch adds the test of bootstrap opac theme.
I did not manage to add the ccsr theme since it is not a real theme, meaning it has no templates and not all includes.

Test by runnning perl xt/author/valid-templates.t and looking at the logs.
The should be 902 test lignes.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Now there are 902 lines, bootstrap tested (1 error detected!)
No koha-qa errors
Comment 3 Bernardo Gonzalez Kriegel 2014-05-16 23:46:56 UTC
One error detected on opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt 
line 242
A mismatched open '('
Comment 4 Katrin Fischer 2014-05-18 11:04:03 UTC
Frido, please remember to assign the bugs to yourself :)
Comment 5 Katrin Fischer 2014-05-18 11:19:25 UTC
I am not sure about this one - I see more errors in:

not ok 782 - /home/katrin/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc
not ok 784 - /home/katrin/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
not ok 773 - /home/katrin/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/search/results.tt
not ok 752 - /home/katrin/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
Comment 6 Bernardo Gonzalez Kriegel 2014-05-18 13:50:59 UTC
(In reply to Katrin Fischer from comment #5)
> I am not sure about this one - I see more errors in:
> 
> not ok 782 -
> /home/katrin/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-
> close.inc
> not ok 784 -
> /home/katrin/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.
> inc
> not ok 773 -
> /home/katrin/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/search/
> results.tt
> not ok 752 -
> /home/katrin/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-
> grouped.tt

was me not runnig the test right, 
found same 'not ok' files, only different number

not ok 714 - /home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
not ok 766 - /home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/search/results.tt
not ok 779 - /home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc
not ok 792 - /home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
Comment 7 Fridolin Somers 2014-05-19 13:55:07 UTC
(In reply to Katrin Fischer from comment #4)
> Frido, please remember to assign the bugs to yourself :)
Yep ok.
Comment 8 Galen Charlton 2014-05-19 16:29:17 UTC
After writing a couple follow-ups to (a) exclude a couple templates that cannot be tested independently in the Bootstrap theme and (b) correct errors to two templates found by the tests of the additional templates, I've judged this important enough to push directly to master.  Thanks, Fridolin!
Comment 9 Fridolin Somers 2014-05-20 07:45:20 UTC
Pushed to 3.14.x, will be in 3.14.07.

Thanks Bernardo, Katrin and Galen. This will provide better templates ;)