You you accept or reject a suggestion using the "Others..." option and entering a reason manually, the text is not showing up in the Bootstrap OPAC theme as it does in CCSR and prog. To test: - Create a suggestion - Accept or reject it entering a reason manually instead of picking one from the pull down list - Switch to prog theme - Look at the suggestion in the OPAC, verify the reason displays - Switch to bootstrap theme - Verify in OPAC that the reason doesn't display
Created attachment 28448 [details] [review] Bug 12280 - "Others..." reason for suggestions not showing in Bootstrap OPAC If you accept or reject a suggestion using the "Others..." option and entering a reason manually, the text is not showing up in the Bootstrap OPAC theme as it does in CCSR and prog. This patch corrects the problem. This patch also adds a missing [% USE AuthorisedValues %] which would cause errors if the template tried to display a custom suggestion status as defined in the SUGGEST_STATUS authorized value category. To test, accept or reject a suggestion and specify a custom reason. View that suggestion in the Bootstrap OPAC and confirm that the custom reason is displayed.
Created attachment 28577 [details] [review] [SIGNED-OFF] Bug 12280 - "Others..." reason for suggestions not showing in Bootstrap OPAC If you accept or reject a suggestion using the "Others..." option and entering a reason manually, the text is not showing up in the Bootstrap OPAC theme as it does in CCSR and prog. This patch corrects the problem. This patch also adds a missing [% USE AuthorisedValues %] which would cause errors if the template tried to display a custom suggestion status as defined in the SUGGEST_STATUS authorized value category. To test, accept or reject a suggestion and specify a custom reason. View that suggestion in the Bootstrap OPAC and confirm that the custom reason is displayed. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Created attachment 28617 [details] [review] Bug 12280 - "Others..." reason for suggestions not showing in Bootstrap OPAC If you accept or reject a suggestion using the "Others..." option and entering a reason manually, the text is not showing up in the Bootstrap OPAC theme as it does in CCSR and prog. This patch corrects the problem. This patch also adds a missing [% USE AuthorisedValues %] which would cause errors if the template tried to display a custom suggestion status as defined in the SUGGEST_STATUS authorized value category. To test, accept or reject a suggestion and specify a custom reason. View that suggestion in the Bootstrap OPAC and confirm that the custom reason is displayed. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Thanks Owen!
Pushed to 3.16.x for inclusion in 3.16.1.