Bug 12280 - "Others..." reason for suggestions not showing in Bootstrap OPAC
Summary: "Others..." reason for suggestions not showing in Bootstrap OPAC
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-18 21:11 UTC by Katrin Fischer
Modified: 2015-06-04 23:30 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12280 - "Others..." reason for suggestions not showing in Bootstrap OPAC (2.28 KB, patch)
2014-05-22 17:29 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12280 - "Others..." reason for suggestions not showing in Bootstrap OPAC (2.33 KB, patch)
2014-05-30 18:51 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 12280 - "Others..." reason for suggestions not showing in Bootstrap OPAC (2.37 KB, patch)
2014-06-02 14:48 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-05-18 21:11:01 UTC
You you accept or reject a suggestion using the "Others..." option and entering a reason manually, the text is not showing up in the Bootstrap OPAC theme as it does in CCSR and prog.

To test:

- Create a suggestion
- Accept or reject it entering a reason manually instead of picking one
  from the pull down list
- Switch to prog theme
- Look at the suggestion in the OPAC, verify the reason displays
- Switch to bootstrap theme
- Verify in OPAC that the reason doesn't display
Comment 1 Owen Leonard 2014-05-22 17:29:21 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2014-05-30 18:51:56 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-06-02 14:48:27 UTC
Created attachment 28617 [details] [review]
Bug 12280 - "Others..." reason for suggestions not showing in Bootstrap OPAC

If you accept or reject a suggestion using the "Others..." option and
entering a reason manually, the text is not showing up in the Bootstrap
OPAC theme as it does in CCSR and prog. This patch corrects the problem.

This patch also adds a missing [% USE AuthorisedValues %] which would
cause errors if the template tried to display a custom suggestion status
as defined in the SUGGEST_STATUS authorized value category.

To test, accept or reject a suggestion and specify a custom reason. View
that suggestion in the Bootstrap OPAC and confirm that the custom reason
is displayed.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Tomás Cohen Arazi 2014-06-04 21:11:03 UTC
Patch pushed to master.

Thanks Owen!
Comment 5 Galen Charlton 2014-06-04 21:17:15 UTC
Pushed to 3.16.x for inclusion in 3.16.1.