Bug 12281 - RTL display for records using 880 broken in Bootstrap
Summary: RTL display for records using 880 broken in Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-18 21:23 UTC by Katrin Fischer
Modified: 2015-06-04 23:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Correct display of results list in prog theme (118.88 KB, image/png)
2014-05-18 21:23 UTC, Katrin Fischer
Details
Incorrect display of results list in bootstrap theme (91.19 KB, image/png)
2014-05-18 21:25 UTC, Katrin Fischer
Details
Correct display of detail page in prog theme (56.26 KB, image/png)
2014-05-18 21:26 UTC, Katrin Fischer
Details
Partially broken detail page in bootstrap theme (67.50 KB, image/png)
2014-05-18 21:27 UTC, Katrin Fischer
Details
Bug 12281: Display for records with RTL script in 880 in Boostrap (85.06 KB, patch)
2014-09-19 13:04 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 12281: Display for records with RTL script in 880 in Boostrap (85.18 KB, patch)
2014-10-10 12:50 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-05-18 21:23:57 UTC
Created attachment 28319 [details]
Correct display of results list in prog theme

If you are using 880 fields for cataloging the original script and the script is RTL, the text should be display aligned right instead of left. This is still working in prog, but not in bootstrap on current master.

Attaching some screenshots.
Comment 1 Katrin Fischer 2014-05-18 21:25:15 UTC
Created attachment 28320 [details]
Incorrect display of results list in bootstrap theme
Comment 2 Katrin Fischer 2014-05-18 21:26:03 UTC
Created attachment 28321 [details]
Correct display of detail page in prog theme
Comment 3 Katrin Fischer 2014-05-18 21:27:02 UTC
Created attachment 28322 [details]
Partially broken detail page in bootstrap theme
Comment 4 Katrin Fischer 2014-09-19 13:04:35 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-09-19 13:11:41 UTC
Documentation: Alternate Graphic Representation 880:

http://www.loc.gov/marc/bibliographic/bd880.html

An example from a record with various 246 fields in different scripts:

246 		
$a On the tip of the tongue : 500 yiddish proverbs

246		
$a ʿAl ḳetseh ha-lashon : 500 pitgeme yidish 

880 
$6 246-02/Cyrl
$a На кончике языка : 500 пословиц идиша 

880 
$6 246-01/Hebr/r
$a על קצה הלשון : 500 פתגמי יידיש
Comment 6 Aleisha Amohia 2014-09-23 04:56:40 UTC
I'm not sure how to turn on RTL to test this? :)
Comment 7 Katrin Fischer 2014-09-23 05:20:58 UTC
Hi Aleisha, it's something that happens automatically when you have a record with the 880 fields - the RTL (read from right to left) scripts will run into the screen from right to the left on detail and result page.
Comment 8 Aleisha Amohia 2014-09-23 05:49:32 UTC
Tested on a sandbox but sign-off feature isn't working so signing off here
Comment 9 Kyle M Hall 2014-10-10 12:50:13 UTC
Created attachment 32133 [details] [review]
[PASSED QA] Bug 12281: Display for records with RTL script in 880 in Boostrap

This patch adds a missing CSS declaration to the Boostrap CSS file
in order to fix the display for RTL script catalogued in tag 880.

To test:
- Catalog or import records using the 880 tag into your catalog
- Compare the prog OPAC detail and rsult view with bootstrap
- Apply patch
- Verfiy now the display in bootstrap is the same as before in
  prog (and also in staff)

Note: Some notes on how to catalog with 880 were added to
the bug report.

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Tomás Cohen Arazi 2014-10-28 14:14:21 UTC
Patch pushed to master.

Thanks Katrina!