Bug 12293 - Remove Problematic Logic from Patron Messaging Preferences Form - bootstrap
Summary: Remove Problematic Logic from Patron Messaging Preferences Form - bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 11125
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-20 14:31 UTC by Jonathan Druart
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12293: Correct display for patron messaging preferences on OPAC - bootstrap (1.39 KB, patch)
2014-05-20 14:34 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12293: Correct display for patron messaging preferences on OPAC - bootstrap (1.46 KB, patch)
2014-06-03 08:31 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
[PASSED QA] Bug 12293: Correct display for patron messaging preferences on OPAC - bootstrap (1.61 KB, patch)
2014-06-09 10:30 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-05-20 14:31:14 UTC
Same issue as Bug 11125.
The bootstrap theme has not been fixed.
Comment 1 Jonathan Druart 2014-05-20 14:34:04 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2014-06-03 08:30:48 UTC
Patch tested with a sandbox, by Axelle Clarisse <koha.aixmarseille@gmail.com>
Comment 3 Biblibre Sandboxes 2014-06-03 08:31:04 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-06-09 10:30:41 UTC
Created attachment 28731 [details] [review]
[PASSED QA] Bug 12293: Correct display for patron messaging preferences on OPAC - bootstrap

This patch is a follow-up for bug 11125, it fixes the bootstrap theme.

Test plan:
1) Remove 'sms' from message_transport_types table.
2) Go on OPAC "My messaging" tab => table columns are out of alignment with table heading.
3) Apply patch => table is correctly displayed.

Signed-off-by: Axelle Clarisse <koha.aixmarseille@gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
With and without 'sms' existing the display of the table is now correct.
Template only change.
Comment 5 Chris Cormack 2014-06-16 20:47:38 UTC
Template only change, pushed to master as Module Maintainer for OPAC