Bug 12297 - Waitingreserves code duplication
Summary: Waitingreserves code duplication
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: paxed
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-21 06:26 UTC by paxed
Modified: 2020-11-30 21:44 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 12297: Fix waitingreserves code duplication (12.78 KB, patch)
2018-08-27 10:08 UTC, paxed 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-05-21 06:26:16 UTC 
waitingreserves.tt has two near-identical tables, holdst and holdso. These should be folded into a single TT BLOCK, which is then called with appropriate parameters to generate the two tables.
Comment 1 paxed 2018-08-27 10:08:21 UTC 
Created attachment 78176 [details] [review]
Bug 12297: Fix waitingreserves code duplication

waitingreserves.tt has two near-identical tables, holdst and holdso.
These should be folded into a single TT BLOCK, which is then called
with appropriate parameters to generate the two tables.
Comment 2 David Nind 2020-02-08 01:31:07 UTC 
Patch no longer applies 8-(
Comment 3 paxed 2020-02-14 10:43:01 UTC 
This is no longer valid anyway, the tables in waitingreserves-page have changed to datatables.