Bug 12298 - The "feed" MTT does not seem to be used
Summary: The "feed" MTT does not seem to be used
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-21 07:58 UTC by Jonathan Druart
Modified: 2015-06-04 23:33 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12298: The "feed" MTT does not seem to be used and can be removed (6.12 KB, patch)
2014-05-21 08:24 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12298: The "feed" MTT does not seem to be used and can be removed (6.10 KB, patch)
2014-05-21 08:25 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12298: The "feed" MTT does not seem to be used and can be removed (6.17 KB, patch)
2014-08-10 21:03 UTC, Nick Clemens
Details | Diff | Splinter Review
[PASSED QA] Bug 12298: The "feed" MTT does not seem to be used and can be removed (6.45 KB, patch)
2014-08-10 21:50 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 12298: The "feed" MTT does not seem to be used and can be removed (6.44 KB, patch)
2014-08-10 21:51 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-05-21 07:58:16 UTC

    
Comment 1 Jonathan Druart 2014-05-21 08:24:40 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-05-21 08:25:50 UTC Comment hidden (obsolete)
Comment 3 Nick Clemens 2014-08-10 21:03:39 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-08-10 21:50:11 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-08-10 21:51:47 UTC
Created attachment 30673 [details] [review]
[PASSED QA] Bug 12298: The "feed" MTT does not seem to be used and can be removed

The feed message transport type exists but nobody knows how it can be
used. This patch assumes nobody uses it and removes it.

Before removing the entry in the DB, the updatedb entry will check if no
foreign key exists in order to avoid a delete in cascade.

This path does *not* deletes the occurrences in the templates.

Test plan:
Apply this patch, execute the updatedb script and verify the
message_transport_types table does not contain the 'feed' entry if it was not
in use.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch will remove the confusing option to configure message texts for feeds.
Checked on a database with an existing feed type notice (not deleted) and
on one without any references to the feed message transport type (deleted!)
Comment 6 Tomás Cohen Arazi 2014-11-25 21:08:10 UTC
Patch pushed to master.

Thanks Jonathan!