When viewing reserved books in the opac in opac-user.pl only title is displayed and no author. This is odd since opac-user.tt actually tries to output [% RESERVE.author %]. The fix seems to be to add $res->{'author'} = $biblioData->{'author'}; at the appropriate place in opac-user.pl so that the template file actually has a value to output in [% RESERVE.author %] Extra cred to cait for helping me out and stripping down my solution to 50% of the code for a total of adding 1 line in 1 file :) If I can wrap my head around git-bz I'll send a patch for this.
Created attachment 28594 [details] [review] Fix for author of reserved book not displaying in Opac 12336 This patch adds a line in opac-user.pl passing author info to opac-user.tt Thanks to cait for helping me out and showing me how to solve this with half the amount of code. Test plan: * Reserve a book. * Go to the opac and log in as the patron you reserved the book for. * Apply the patch with change to opac-user.pl * Revisit the opac and refresh it. * See if author now shows up
Created attachment 28622 [details] [review] Bug 12336 - [SIGNED-OFF] Author of reserved book is not displayed in opac-user.pl This patch adds a line in opac-user.pl passing author info to opac-user.tt Thanks to cait for helping me out and showing me how to solve this with half the amount of code. Test plan: * Reserve a book. * Go to the opac and log in as the patron you reserved the book for. * Apply the patch with change to opac-user.pl * Revisit the opac and refresh it. * See if author now shows up Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Created a hold. Author is not shown n the public catalogue before applying the patch, but it does show after applying the patch. Way to go, Viktor!
Created attachment 28632 [details] [review] Bug 12336 - [SIGNED-OFF] Author of reserved book is not displayed in opac-user.pl This patch adds a line in opac-user.pl passing author info to opac-user.tt Thanks to cait for helping me out and showing me how to solve this with half the amount of code. Test plan: * Reserve a book. * Go to the opac and log in as the patron you reserved the book for. * Apply the patch with change to opac-user.pl * Revisit the opac and refresh it. * See if author now shows up Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Created a hold. Author is not shown n the public catalogue before applying the patch, but it does show after applying the patch. Way to go, Viktor! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I think this is more a bugfix than an enh.
(In reply to Jonathan Druart from comment #4) > I think this is more a bugfix than an enh. I agree Jonathan. I fixes that opac-user.tt tries to output a value that opac-user.pl don't create. I understand that I should add [ENH] to enh. bugs - is there something I should do to flag it as a bug?
(In reply to Viktor Sarge from comment #5) > I agree Jonathan. I fixes that opac-user.tt tries to output a value that > opac-user.pl don't create. I understand that I should add [ENH] to enh. bugs > - is there something I should do to flag it as a bug? You can just change the severity with the dropdown list near "Importance:". The values are "critical", "normal", ..., "enhancement", "new feature".
Patch pushed to master. Thanks Viktor!
Pushed to 3.16.x for inclusion in 3.16.1. Congratulations for having your first patch accepted into Koha, Viktor!
Thank you! This is great fun. And the timing is spotless - now I can publish post #100 on our blog with the news of my first patch being accepted :) (In reply to Galen Charlton from comment #8) > Pushed to 3.16.x for inclusion in 3.16.1. > > Congratulations for having your first patch accepted into Koha, Viktor!