Registering a new patron, click on the date of birth -date picker, the year dropdown only shows 10 years (eg. 2004 - 2014). It should show 20 years, to catch most patrons to be registered.
Well it should show _at least_ 20 entries. And it should start five years in the past, since patrons creation requests for the age from 0 years to 5 years are not dropping in that frequently. Do they?
Created attachment 39089 [details] [review] Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 100 years from the current date. Default value selected is current date minus 15 years; this assumes that 15 years is a common age for new patrons. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The default selected date will be current date minus one. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The default selected date should be current year minus 15. - The year selection drop-down should show current year minus 100.
Created attachment 39098 [details] [review] Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 100 years from the current date. Default value selected is current date minus 15 years; this assumes that 15 years is a common age for new patrons. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The default selected date will be current date minus one. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The default selected date should be current year minus 15. - The year selection drop-down should show current year minus 100. Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no>
Hello Martin Very useful patch, thanks! Could you have a look at the following template: opac-memberentry.tt: $( "#borrower_dateofbirth" ).datepicker({ yearRange: "c-120:c" }); To be consistent, it would be good to have the same value everywhere. Feel free to replace 120 with 100 or vice versa.
Switch the status back to Signed Off when done.
Created attachment 45379 [details] [review] Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 100 years from the current date. Default value selected is current date minus 15 years; this assumes that 15 years is a common age for new patrons. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The default selected date will be current date minus one. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The default selected date should be current year minus 15. - The year selection drop-down should show current year minus 100. Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no>
Created attachment 45380 [details] [review] Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 120 years from the current date. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The year selection drop-down should show current year minus 120.
Created attachment 45381 [details] [review] Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 120 years from the current date. Updated version with proper description and default value moved to a separate bug/commit. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The year selection drop-down should show current year minus 120.
Created attachment 45389 [details] [review] [SIGNED-OFF]Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 120 years from the current date. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The year selection drop-down should show current year minus 120. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
I realized I should have changed the format string to "c-120:c", but since it is signed off.. well, hardly worth it. Doing it would allow us to drop the "maxDate" attribute.
(In reply to Martin Persson from comment #10) > I realized I should have changed the format string to "c-120:c", but since > it is signed off.. well, hardly worth it. Doing it would allow us to drop > the "maxDate" attribute. Hi Martin If you want to do another change in patch, do it, I will sign-off again. Regards
This seems to work fine as it is - passing QA. Please let me know if you want to do a follow-up.
Created attachment 45433 [details] [review] [PASSED QA] Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 120 years from the current date. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The year selection drop-down should show current year minus 120. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master, thanks Martin!
This is quite annoying for circulation staff - marking as 'minor' in hope for it to get picked up by rmaints.
*** Bug 15515 has been marked as a duplicate of this bug. ***
(In reply to Kyle M Hall from comment #14) > Pushed to master, thanks Martin! Cant see it in current master has the patch been dropped?
(In reply to Colin Campbell from comment #17) > (In reply to Kyle M Hall from comment #14) > > Pushed to master, thanks Martin! > > Cant see it in current master has the patch been dropped? 7d3772503c Bug 12342: Patron registration datepicker dropdown shows only 10 years
Although the patch was applied patch code no longer there the bug has been reinstated and is being reported - marking as reopened
Been doing some detective work on this one. It seems Bug 15692 moved the datepicker jquery javascript into /koha-tmpl/intranet-tmpl/prog/en/js/members.js, with the patch from this bug still intact. Then Bug 16242 moved the staff client javascript out of the language directory, so /koha-tmpl/intranet-tmpl/prog/en/js/members.js became /koha-tmpl/intranet-tmpl/prog/js/members.js Looking at the log history of this moved file, it appears that the code was then changed in bug 18477, which references this bug. That's been pushed to master more recently than this bug has last been updated, so can we assume that this bug can now be closed again?