Due to the way members-home.pl handles the variable $branch, the number of patron modifications listed on members-home.pl may differ from the number listed on mainpage.pl. When the librarian clicks this link, he or she may see a different number than was listed, or none at all!
Created attachment 28621 [details] [review] Bug 12346 - False patron modification alerts on members-home.pl Due to the way members-home.pl handles the variable $branch, the number of patron modifications listed on members-home.pl may differ from the number listed on mainpage.pl. When the librarian clicks this link, he or she may see a different number than was listed, or none at all! Test Plan: 1) Create a number of modification request for BranchA 2) Log into the staff intranet and set your branch to BranchB 3) Note the modifications alert to does display on mainpage.pl 4) Click the "Patrons" link to take you to members-home.pl 5) Note the modifictions alert does display on this page 6) Apply this patch 7) Reload members-home.pl, note the alert no longer displays
Kyle, I am not seeing that behavior on master. Can you confirm the steps, and maybe include a quick video? Christopher
I was able to reproduce your problem, but I got the following when I tried to use the members-home with the patch: Global symbol "$flags" requires explicit package name at /home/liz/koha-src/koha/members/members-home.pl line 97. Execution of /home/liz/koha-src/koha/members/members-home.pl aborted due to compilation errors. (Plus there was a minor conflict which seemed straightforward enough so I fixed that up, but still no luck.) Liz
Hm, actually let me give that one more go...
I missed a thing in the merge issue - I got this to work so I'll have another look tomorrow - sorry about that. Liz
I submitted modifications from patrons with several different home libraries (borrowers.branchcode) and logged in to the staff client using accounts from a couple of different libraries but I didn't see any difference in the count of pending patron modifications. It counted and displayed all pending modifications.
Still can't reproduce this.
Created attachment 66880 [details] [review] Bgu 12346: Display the correct number of pending patron modifications on the patron module home page Due to the way members-home.pl handles the variable $branch, the number of patron modifications listed on members-home.pl may differ from the number listed on mainpage.pl. When the librarian clicks this link, he or she may see a different number than was listed, or none at all! Test Plan: 0) Set IndependentBranchesPatronModifications = Yes 1) Create a number of modification request for BranchA 2) Log into the staff intranet with a patron without superlibrarian permissions and set your branch to BranchB 3) Note the modifications alert to does not display on mainpage.pl 4) Click the "Patrons" link to take you to members-home.pl 5) Note the modifictions alert does display on this page 6) Apply this patch 7) Reload members-home.pl, note the alert no longer displays QA notes: What was the point of the branch variable?
Still valid, I have updated the patch and test plan.
Created attachment 66966 [details] [review] Bgu 12346: Display the correct number of pending patron modifications on the patron module home page Due to the way members-home.pl handles the variable $branch, the number of patron modifications listed on members-home.pl may differ from the number listed on mainpage.pl. When the librarian clicks this link, he or she may see a different number than was listed, or none at all! Test Plan: 0) Set IndependentBranchesPatronModifications = Yes 1) Create a number of modification request for BranchA 2) Log into the staff intranet with a patron without superlibrarian permissions and set your branch to BranchB 3) Note the modifications alert to does not display on mainpage.pl 4) Click the "Patrons" link to take you to members-home.pl 5) Note the modifictions alert does display on this page 6) Apply this patch 7) Reload members-home.pl, note the alert no longer displays QA notes: What was the point of the branch variable? Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Created attachment 67046 [details] [review] Bgu 12346: Display the correct number of pending patron modifications on the patron module home page Due to the way members-home.pl handles the variable $branch, the number of patron modifications listed on members-home.pl may differ from the number listed on mainpage.pl. When the librarian clicks this link, he or she may see a different number than was listed, or none at all! Test Plan: 0) Set IndependentBranchesPatronModifications = Yes 1) Create a number of modification request for BranchA 2) Log into the staff intranet with a patron without superlibrarian permissions and set your branch to BranchB 3) Note the modifications alert to does not display on mainpage.pl 4) Click the "Patrons" link to take you to members-home.pl 5) Note the modifictions alert does display on this page 6) Apply this patch 7) Reload members-home.pl, note the alert no longer displays QA notes: What was the point of the branch variable? Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.06.
This patch has been pushed to 16.11.x and will be in 16.11.14.