On the holds queue the hidepatron name preference is ignored and the name is shown all the time. It should be hidden.
I have a patch for this, but I am not sure if we should make the change. The pref description seems to not include the holds report pages: Show/Don't show the names of patrons that have items checked out or on hold on detail pages or the "Place Hold" screen.
Created attachment 33439 [details] [review] Bug 12359: Add HidePatronName functionality to the holds queue This changes the Holds Queue page to not show the patron's name and phone number, but only the cardnumber, when HidePatronName is set to 'Don't show' This also changes the link to the patron account to use the borrowernumber instead of the cardnumber, which seems more consistent. Fixes a tiny capitalization error: Only item... To test: - Look at the holds queue page with holds displayed - Toggle HidePatronName system preference and observe the change - Make sure the link works correctly
Setting in discussion to get some feedback about the suggested change.
Still valid?
Created attachment 56571 [details] [review] Bug 12359: Add HidePatronName functionality to the holds queue This changes the Holds Queue page to not show the patron's name and phone number, but only the cardnumber, when HidePatronName is set to 'Don't show' This also changes the link to the patron account to use the borrowernumber instead of the cardnumber, which seems more consistent. Fixes a tiny capitalization error: Only item... To test: - Look at the holds queue page with holds displayed - Toggle HidePatronName system preference and observe the change - Make sure the link works correctly Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Rebased 2016-10-16
Still valid, rebased patch - leaving it up to testers.
>This also changes the link to the patron account to use >the borrowernumber instead of the cardnumber, which seems >more consistent Katrin, After applying the patch, I still see the cardnumber, not borrowernumber, in the holds queue page (and on the hold details page).
You mean in the link or in the text shown? With the patch HidePatronName should toggle between cardnumber and displaying the name.
>With the patch HidePatronName should toggle between cardnumber and displaying >the name. Yes, it does toggle between cardnumber and displaying the name. If so, the behavior is as expected. I guess I am confused by what what you mean by saying the link uses the borrowernumber instead of the cardnumber. Is this is a matter of functionality rather than display?
Yes :) I also changed the URL behind the link - it was using the cardnumber and I changed it to use the borrowernumber instead for linking. If the link to the patron account still works, things should be alright.
Yes, the link to the patron account still works. Thanks for the clarification.
Created attachment 56847 [details] [review] Bug 12359: Add HidePatronName functionality to the holds queue This changes the Holds Queue page to not show the patron's name and phone number, but only the cardnumber, when HidePatronName is set to 'Don't show' This also changes the link to the patron account to use the borrowernumber instead of the cardnumber, which seems more consistent. Fixes a tiny capitalization error: Only item... To test: - Look at the holds queue page with holds displayed - Toggle HidePatronName system preference and observe the change - Make sure the link works correctly Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Rebased 2016-10-16 Signed-off-by: Chris Kirby <christopherlawrencekirby@gmail.com>
Created attachment 57637 [details] [review] Bug 12359: Add HidePatronName functionality to the holds queue This changes the Holds Queue page to not show the patron's name and phone number, but only the cardnumber, when HidePatronName is set to 'Don't show' This also changes the link to the patron account to use the borrowernumber instead of the cardnumber, which seems more consistent. Fixes a tiny capitalization error: Only item... To test: - Look at the holds queue page with holds displayed - Toggle HidePatronName system preference and observe the change - Make sure the link works correctly Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Rebased 2016-10-16 Signed-off-by: Chris Kirby <christopherlawrencekirby@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master for 16.11, thanks Katrin!
Pushed to 16.05.x, for 16.05.06 release