Bug 12377 - Add date pickers to serials-edit.pl
Summary: Add date pickers to serials-edit.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-05 17:48 UTC by Kyle M Hall
Modified: 2015-06-04 23:33 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12377 - Add date pickers to serials-edit.pl (4.20 KB, patch)
2014-06-05 17:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12377 - Add date pickers to serials-edit.pl (4.25 KB, patch)
2014-06-10 05:22 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 12377 [QA Followup] - Remove readonly from input (2.52 KB, patch)
2014-07-11 16:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12377 - Add date pickers to serials-edit.pl (4.32 KB, patch)
2014-07-15 08:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12377 [QA Followup] - Remove readonly from input (2.59 KB, patch)
2014-07-15 08:21 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-06-05 17:48:22 UTC
There are two date fields when receiving serials on serials-edit.pl, these input should have a calendar widget like other date fields in Koha.
Comment 1 Kyle M Hall 2014-06-05 17:50:43 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2014-06-10 05:21:47 UTC
Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com>
Comment 3 Biblibre Sandboxes 2014-06-10 05:22:05 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-06-10 09:13:25 UTC
Why did you set the readonly attributes on the second input?
Comment 5 Jonathan Druart 2014-06-19 12:17:09 UTC
Kyle, can I get an answer please?
Comment 6 Kyle M Hall 2014-07-11 16:59:48 UTC Comment hidden (obsolete)
Comment 7 Kyle M Hall 2014-07-11 17:00:38 UTC
(In reply to Jonathan Druart from comment #4)
> Why did you set the readonly attributes on the second input?

My bad! Followup to fix issue is attached.
Comment 8 Jonathan Druart 2014-07-15 08:21:06 UTC
Created attachment 29694 [details] [review]
Bug 12377 - Add date pickers to serials-edit.pl

There are two date fields when receiving serials on serials-edit.pl,
these inputs should have a calendar widget like other date fields
in Koha.

Test Plan:
1) Apply this patch
2) Recieve a serial
3) Note when clicking on the "Published on" or "Expected on" fields
   you will now have a calendar popup. Note you can still manually
   edit the date if you wish to.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 9 Jonathan Druart 2014-07-15 08:21:10 UTC
Created attachment 29695 [details] [review]
Bug 12377 [QA Followup] - Remove readonly from input

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 10 Tomás Cohen Arazi 2014-07-15 15:18:34 UTC
Patches pushed to master.

Thanks Kyle!