Bug 12380 - can't tab to save buttons on add item
Summary: can't tab to save buttons on add item
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
: 11597 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-06-06 17:19 UTC by Nicole C. Engard
Modified: 2015-06-04 23:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12380 - can't tab to save buttons on add item (2.19 KB, patch)
2014-06-09 13:02 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12380 - can't tab to save buttons on add item (2.22 KB, patch)
2014-06-10 00:28 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 12380 - can't tab to save buttons on add item (2.27 KB, patch)
2014-06-10 13:48 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2014-06-06 17:19:57 UTC
When adding/editing an item on additem.pl if you hit tab through all the subfields when you get to the end you expect the tab to go to the 'add item' buttons but it doesn't - it goes back to the top. Can we get the buttons included in the tab order?
Comment 1 Owen Leonard 2014-06-09 13:02:54 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2014-06-10 00:28:09 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-06-10 13:48:00 UTC
Created attachment 28759 [details] [review]
Bug 12380 - can't tab to save buttons on add item

Many form elements on the add item page are giving a tabindex of "1" by
the script. This seems to make it impossible to tab through the add item
form fields onto the save buttons. I don't see a reason to set an
explicit tabindex of "1," so this patch removes it.

To test, apply the patch and open an item for editing. Try tabbing
through the add item form fields. It should be possible to tab through
the fields and onto the submit buttons at the bottom. Test again when
adding a new item.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Tomás Cohen Arazi 2014-06-16 19:03:45 UTC
Patch pushed to master.

Thanks Owen!
Comment 5 Galen Charlton 2014-06-18 21:13:48 UTC
Pushed to 3.16.x for inclusion in 3.16.1.
Comment 6 Owen Leonard 2014-07-18 15:47:08 UTC
*** Bug 11597 has been marked as a duplicate of this bug. ***