When adding/editing an item on additem.pl if you hit tab through all the subfields when you get to the end you expect the tab to go to the 'add item' buttons but it doesn't - it goes back to the top. Can we get the buttons included in the tab order?
Created attachment 28734 [details] [review] Bug 12380 - can't tab to save buttons on add item Many form elements on the add item page are giving a tabindex of "1" by the script. This seems to make it impossible to tab through the add item form fields onto the save buttons. I don't see a reason to set an explicit tabindex of "1," so this patch removes it. To test, apply the patch and open an item for editing. Try tabbing through the add item form fields. It should be possible to tab through the fields and onto the submit buttons at the bottom. Test again when adding a new item.
Created attachment 28750 [details] [review] [SIGNED-OFF] Bug 12380 - can't tab to save buttons on add item Many form elements on the add item page are giving a tabindex of "1" by the script. This seems to make it impossible to tab through the add item form fields onto the save buttons. I don't see a reason to set an explicit tabindex of "1," so this patch removes it. To test, apply the patch and open an item for editing. Try tabbing through the add item form fields. It should be possible to tab through the fields and onto the submit buttons at the bottom. Test again when adding a new item. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Created attachment 28759 [details] [review] Bug 12380 - can't tab to save buttons on add item Many form elements on the add item page are giving a tabindex of "1" by the script. This seems to make it impossible to tab through the add item form fields onto the save buttons. I don't see a reason to set an explicit tabindex of "1," so this patch removes it. To test, apply the patch and open an item for editing. Try tabbing through the add item form fields. It should be possible to tab through the fields and onto the submit buttons at the bottom. Test again when adding a new item. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Thanks Owen!
Pushed to 3.16.x for inclusion in 3.16.1.
*** Bug 11597 has been marked as a duplicate of this bug. ***