Bug 12386 - 'Days in advance' pull down in bootstrap OPAC is huge
Summary: 'Days in advance' pull down in bootstrap OPAC is huge
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-09 10:26 UTC by Katrin Fischer
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
screenshot of 'your messaging' in bootstrap OPAC (21.02 KB, image/png)
2014-06-09 10:26 UTC, Katrin Fischer
Details
Bug 12386 - 'Days in advance' pull down in bootstrap OPAC is huge (1.91 KB, patch)
2014-06-30 18:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Class input-mini has no effect (71.35 KB, image/png)
2014-06-30 19:25 UTC, Marc Véron
Details
Bug 12386 - 'Days in advance' pull down in bootstrap OPAC is huge (1.92 KB, patch)
2014-07-01 04:50 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 12386 - 'Days in advance' pull down in bootstrap OPAC is huge (1.99 KB, patch)
2014-07-01 14:35 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-06-09 10:26:42 UTC
Created attachment 28730 [details]
screenshot of 'your messaging' in bootstrap OPAC

In the bootstrap opac the pull down to set the days in advance for the reminder email is too long for the content it displays. Not sure if there is a reason for it or of it is a problem.
Comment 1 Marc Véron 2014-06-10 20:38:36 UTC
Workaround in system preference OPACUserCSS:

#usermessaging table {
    max-width: 560px;
}

#usermessaging select {
    width: 110px;
}
Comment 2 Owen Leonard 2014-06-30 18:14:15 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2014-06-30 19:25:21 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2014-06-30 19:35:53 UTC
(In reply to Marc Véron from comment #1)

> The patch introduces class .input-mini (with 60px), but it is overwritten by
> #usermessaging select

From your OPACUserCSS?
Comment 5 Biblibre Sandboxes 2014-07-01 04:49:42 UTC
Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com>
Comment 6 Biblibre Sandboxes 2014-07-01 04:50:06 UTC Comment hidden (obsolete)
Comment 7 Marc Véron 2014-07-01 09:47:41 UTC
Comment on attachment 29387 [details]
Class input-mini has no effect

Obsoleting this screenshot - It was a mistake (Entry in OPACUserCSS)
Comment 8 Jonathan Druart 2014-07-01 14:35:25 UTC
Created attachment 29409 [details] [review]
Bug 12386 - 'Days in advance' pull down in bootstrap OPAC is huge

The "days in advance" form field on the "Your messaging settings" page
in the OPAC has a Bootstrap-default width which is too wide. This patch
adds a class to give it a more reasonable size.

To test you must have the EnhancedMessagingPreferences preference set to
"Allow." Log in to the OPAC and view the messaging settings page. The
dropdown menu of numbers should look correct.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 9 Tomás Cohen Arazi 2014-07-02 18:56:05 UTC
Patch pushed to master.

Thanks Owen!