Koha needs to list IO::Socket::SSL and Crypt::SSLeay as dependencies; if these modules are not installed, the OverDrive code cannot get an authentication token over SSL.
Misspoke, seems only IO::Socket::SSL is required.
Created attachment 28751 [details] [review] Bug 12393 - Depend on SSL module for LWP, for OverDrive The OverDrive integration needs to connect to an authentication server over HTTPS, and many systems do not install the necessary module (LWP::Protocol::https) by default. Test plan (for patch): 1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in listing. Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive access): 1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian). 2) Run an OverDrive search on the OPAC, it should fail. 3) Reinstall LWP::Protocol::https. 4) Rerun OverDrive search, it should now succeed. Note: older versions of Debian do not need to install LWP::Protocol::https separately; the Debian scripts have been updated to reflect this divide.
Created attachment 28961 [details] [review] Bug 12393 - Depend on SSL module for LWP, for OverDrive The OverDrive integration needs to connect to an authentication server over HTTPS, and many systems do not install the necessary module (LWP::Protocol::https) by default. Test plan (for patch): 1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in listing. Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive access): 1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian). 2) Run an OverDrive search on the OPAC, it should fail. 3) Reinstall LWP::Protocol::https. 4) Rerun OverDrive search, it should now succeed. Note: older versions of Debian do not need to install LWP::Protocol::https separately; the Debian scripts have been updated to reflect this divide. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 29055 [details] [review] [SIGNED-OFF] Bug 12393 - Depend on SSL module for LWP, for OverDrive The OverDrive integration needs to connect to an authentication server over HTTPS, and many systems do not install the necessary module (LWP::Protocol::https) by default. Test plan (for patch): 1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in listing. Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive access): 1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian). 2) Run an OverDrive search on the OPAC, it should fail. 3) Reinstall LWP::Protocol::https. 4) Rerun OverDrive search, it should now succeed. Note: older versions of Debian do not need to install LWP::Protocol::https separately; the Debian scripts have been updated to reflect this divide. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 29061 [details] [review] [PASSED QA] Bug 12393 - Depend on SSL module for LWP, for OverDrive The OverDrive integration needs to connect to an authentication server over HTTPS, and many systems do not install the necessary module (LWP::Protocol::https) by default. Test plan (for patch): 1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in listing. Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive access): 1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian). 2) Run an OverDrive search on the OPAC, it should fail. 3) Reinstall LWP::Protocol::https. 4) Rerun OverDrive search, it should now succeed. Note: older versions of Debian do not need to install LWP::Protocol::https separately; the Debian scripts have been updated to reflect this divide. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script.
Patch pushed to master. Thanks Jesse!
Pushed to 3.16.x for inclusion in 3.16.1.