Created attachment 28758 [details] footer printing near top When printing the OPAC in Bootstrap on 3.14 and master the footer prints at the top - see attached.
I can confirm this behaviour. It displays the Koha credits at the wrong place as well. To reproduce: In Opac with Bootstrap theme, do a search with many results. It seems that the credits should not display at all in print version, because in opac-tmpl/bootstrap/css/print.css, line 205, a class .koha_url gets "display:none". However, there is no class koha_url in the HTML code, but an Id koha_url that should be addressed as #koha_url Regarding the Id opaccredits (containing the contents from system preference opaccredits), I do not find any traces in print.css
Still valid in current master 3.19.00.008 Additionally, Language selector displays at top of page 2 and overlays other text.
Created attachment 35711 [details] [review] Bug 12399 - opaccredits printing at top on printable version This patch introduces a new class "noprint" in koha-tmpl/opac-tmpl/bootstrap/css/print.css With this class, unwanted elements can be hidden when printing. To test: In OPAC, do a search with many results (> 1 Page) Print page or do a print preview See that footer elements are not displayed correctly (as of screenshot in comment #1) and that on top of page 2 the language selector overlays the list Apply patch Repeat steps above. Verify that printed page looks much nicer now by hiding unwanted elements (including e.g. RSS icon, toolbar etc.) This mechanism can be used on other pages as well.
Created attachment 36263 [details] [review] Bug 12399 - opaccredits printing at top on printable version This patch introduces a new class "noprint" in koha-tmpl/opac-tmpl/bootstrap/css/print.css With this class, unwanted elements can be hidden when printing. To test: In OPAC, do a search with many results (> 1 Page) Print page or do a print preview See that footer elements are not displayed correctly (as of screenshot in comment #1) and that on top of page 2 the language selector overlays the list Apply patch Repeat steps above. Verify that printed page looks much nicer now by hiding unwanted elements (including e.g. RSS icon, toolbar etc.) This mechanism can be used on other pages as well. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 36536 [details] [review] [PASSED QA] Bug 12399 - opaccredits printing at top on printable version This patch introduces a new class "noprint" in koha-tmpl/opac-tmpl/bootstrap/css/print.css With this class, unwanted elements can be hidden when printing. To test: In OPAC, do a search with many results (> 1 Page) Print page or do a print preview See that footer elements are not displayed correctly (as of screenshot in comment #1) and that on top of page 2 the language selector overlays the list Apply patch Repeat steps above. Verify that printed page looks much nicer now by hiding unwanted elements (including e.g. RSS icon, toolbar etc.) This mechanism can be used on other pages as well. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 36537 [details] [review] Bug 12399: Small change to remove the whole paging Previous patch only removed the next and previous buttons. This patch changes it a bit to remove the whole paging from the print view of the page.
Created attachment 36538 [details] [review] Bug 12399 - opaccredits printing at top on printable version This patch introduces a new class "noprint" in koha-tmpl/opac-tmpl/bootstrap/css/print.css With this class, unwanted elements can be hidden when printing. To test: In OPAC, do a search with many results (> 1 Page) Print page or do a print preview See that footer elements are not displayed correctly (as of screenshot in comment #1) and that on top of page 2 the language selector overlays the list Apply patch Repeat steps above. Verify that printed page looks much nicer now by hiding unwanted elements (including e.g. RSS icon, toolbar etc.) This mechanism can be used on other pages as well. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 36539 [details] [review] Bug 12399: Small change to remove the whole paging Previous patch only removed the next and previous buttons. This patch changes it a bit to remove the whole paging from the print view of the page. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Patches pushed to master. Thanks Marc!
String changes held for 3.18.6
Pushed to 3.18.x will be in 3.18.6