Bug 12407 - phone label or data switched
Summary: phone label or data switched
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Brendon Ford
QA Contact: Marcel de Rooy
URL:
Keywords:
: 8760 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-06-11 15:56 UTC by Nicole C. Engard
Modified: 2015-06-04 23:33 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
enter data (19.63 KB, image/png)
2014-06-11 15:56 UTC, Nicole C. Engard
Details
data display (10.62 KB, image/png)
2014-06-11 15:57 UTC, Nicole C. Engard
Details
Fix for switched phone numbers on patron details page. (3.38 KB, patch)
2014-06-16 19:11 UTC, Brendon Ford
Details | Diff | Splinter Review
Fix for switched phone numbers on patron details page. (3.92 KB, patch)
2014-06-16 21:22 UTC, Brendon Ford
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12407 - phone label or data switched (3.96 KB, patch)
2014-06-17 13:40 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 12407 - phone label or data switched (4.05 KB, patch)
2014-07-31 12:14 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 12407: [QA Follow-up] Rename Other Phone to Mobile in staff (3.78 KB, patch)
2014-07-31 12:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 12407: (QA followup) last occurence of 'Other phone' renamed to 'Mobile phone' (1.07 KB, patch)
2014-08-05 23:39 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2014-06-11 15:56:59 UTC
Created attachment 28785 [details]
enter data

See attached image. You enter date in the secondary and other phone fields on the patron form and it shows next to the opposite label on the patron record.
Comment 1 Nicole C. Engard 2014-06-11 15:57:12 UTC
Created attachment 28786 [details]
data display
Comment 2 Brendon Ford 2014-06-16 19:11:22 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2014-06-16 20:20:55 UTC
Brendon,

Every patch needs a test plan. So after your description type something like :

To Test:

1. 
2. 
etc etc

So that people can test to be sure the patch works.
Comment 4 Brendon Ford 2014-06-16 20:48:17 UTC
Sorry about that Nicole. Thanks for the info.

To Test:

1. Create/modify a patron entering some unique data into the "Secondary phone:" and "Other phone:" fields (different data for each).
2. Save the patron record.
3. Go to the patrons details page and make sure the data entered into the "Secondary phone:" field is displaying next to the "Secondary phone:" label and that the data entered into the "Other phone:" field is displaying next to the "Other phone:" label.
Comment 5 Brendon Ford 2014-06-16 21:22:05 UTC Comment hidden (obsolete)
Comment 6 Nicole C. Engard 2014-06-17 13:40:01 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2014-07-03 15:16:00 UTC
This looks similar to bug 8760 - maybe someone can take a look?
Comment 8 Marcel de Rooy 2014-07-31 12:14:53 UTC
Created attachment 30393 [details] [review]
Bug 12407 - phone label or data switched

Fix for switched phone numbers on patron details page.

This patch fixes switched phone numbers on patron details page and also makes phone number labels more uniform.

To Test:

1. Apply the patch.
2. Create/modify a patron entering some unique data into the "Secondary phone:" and "Other phone:" fields (different data for each).
3. Save the patron record.
4. Go to the patrons details page and make sure the data entered into the "Secondary phone:" field is displaying next to the "Secondary phone:" label and that the data entered into the "Other phone:" field is displaying next to the "Other phone:" label.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Marcel de Rooy 2014-07-31 12:28:31 UTC
Created attachment 30394 [details] [review]
Bug 12407: [QA Follow-up] Rename Other Phone to Mobile in staff

Touches three member templates.
Changes label Other into Mobile.
This is consistent with database field name and OPAC.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Marcel de Rooy 2014-07-31 12:31:23 UTC
QA Comment:
Looks good to me. 
With reference to bug 8760, I added a QA follow-up to rename Other to Mobile in three member templates.

Also note that the field names in the database such as phonepro for secondary phone do not make it easier.
Will put a note on the other report too.

Passed QA
Comment 11 Marcel de Rooy 2014-07-31 12:31:43 UTC
*** Bug 8760 has been marked as a duplicate of this bug. ***
Comment 12 David Cook 2014-08-01 04:28:16 UTC
(In reply to M. de Rooy from comment #9)
> Created attachment 30394 [details] [review] [review]
> Bug 12407: [QA Follow-up] Rename Other Phone to Mobile in staff
> 
> Touches three member templates.
> Changes label Other into Mobile.
> This is consistent with database field name and OPAC.
> 
> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Yay! I sent a patch for this ages ago ( bug 9383 ), but it was tangled up in a few too many other changes, so I'm happy to see this pass QA finally!
Comment 13 Tomás Cohen Arazi 2014-08-05 23:39:35 UTC
Created attachment 30549 [details] [review]
Bug 12407: (QA followup) last occurence of 'Other phone' renamed to 'Mobile phone'

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Comment 14 Tomás Cohen Arazi 2014-08-05 23:55:06 UTC
Patch pushed to master.

Thanks Brendon!
Comment 15 Fred P 2014-08-20 15:46:07 UTC
Great job solving this, but we continue to have issues defining multiple phone numbers. Why do we maintain four separate phone numbers: Primary, secondary, other and SMS number? Most people have a mobile phone - that should be listed first - the SMS number does not need to be a separate field from mobile. Some people have a landline, work phone or alternate number, however Koha doesn't use these alternate numbers, they are only used by Circulation staff, and in our system they are redundant and do not get used. How many people have four phone numbers? Two fields and a duplication of mobile to SMS is sufficient. Maybe a plus sign to add additional numbers if absolutely necessary. By confusing primary, secondary, other and SMS, we get confusion about which field means what. Labeling one number as "Mobile" seems like a logical solution.
Comment 16 Fred P 2014-08-20 15:50:22 UTC
Oops! Looks like I didn't implement the patch yet. Now I see that it is displaying as "mobile." My apologies for the confusion.