Bug 12416 - DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t
Summary: DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Yohann Dufour
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-13 09:18 UTC by Yohann Dufour
Modified: 2015-06-04 23:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12416: add the test of DelUniqueDebarment (1.64 KB, patch)
2014-06-13 09:56 UTC, Yohann Dufour
Details | Diff | Splinter Review
Bug 12416: add the test of DelUniqueDebarment (1.64 KB, patch)
2014-06-16 07:17 UTC, Yohann Dufour
Details | Diff | Splinter Review
Bug 12416: the subroutine 'ok' is replaced by the subroutine 'is' (4.88 KB, patch)
2014-06-16 07:40 UTC, Yohann Dufour
Details | Diff | Splinter Review
Bug 12416: add new tests of DelUniqueDebarment (3.11 KB, patch)
2014-06-16 08:22 UTC, Yohann Dufour
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12416: add the test of DelUniqueDebarment (1.74 KB, patch)
2014-06-22 03:35 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12416: the subroutine 'ok' is replaced by the subroutine 'is' (4.98 KB, patch)
2014-06-22 03:35 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12416: add new tests of DelUniqueDebarment (3.22 KB, patch)
2014-06-22 03:36 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12416: add the test of DelUniqueDebarment (1.79 KB, patch)
2014-06-22 20:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 12416: the subroutine 'ok' is replaced by the subroutine 'is' (5.04 KB, patch)
2014-06-22 20:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 12416: add new tests of DelUniqueDebarment (3.30 KB, patch)
2014-06-22 20:07 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Yohann Dufour 2014-06-13 09:18:55 UTC
The subroutine DelUniqueDebarment (Koha/Borrower/Debarments.pm) is not tested in t/db_dependent/Borrower_Debarments.t
Comment 1 Yohann Dufour 2014-06-13 09:56:22 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-06-13 14:51:08 UTC
Yohann,

Please prefer the use of "is" instead of "ok".

Marked as Failed QA.
Comment 3 Jonathan Druart 2014-06-13 14:53:51 UTC
Adding unit tests is far from being 'minor' :)
Switch the severity back to normal.
Comment 4 Yohann Dufour 2014-06-16 07:17:09 UTC Comment hidden (obsolete)
Comment 5 Yohann Dufour 2014-06-16 07:40:32 UTC Comment hidden (obsolete)
Comment 6 Yohann Dufour 2014-06-16 08:22:32 UTC Comment hidden (obsolete)
Comment 7 Bernardo Gonzalez Kriegel 2014-06-22 03:35:49 UTC Comment hidden (obsolete)
Comment 8 Bernardo Gonzalez Kriegel 2014-06-22 03:35:56 UTC Comment hidden (obsolete)
Comment 9 Bernardo Gonzalez Kriegel 2014-06-22 03:36:04 UTC Comment hidden (obsolete)
Comment 10 Katrin Fischer 2014-06-22 20:06:32 UTC
Created attachment 29148 [details] [review]
[PASSED QA] Bug 12416: add the test of DelUniqueDebarment

The subroutine DelUniqueDebarment was not tested

To test: execute the command prove t/db_dependent/Borrower_Debarments.t
The command has to print:
t/db_dependent/Borrower_Debarments.t .. ok
All tests successful.
Files=1, Tests=22,  2 wallclock secs ( 0.03 usr  0.01 sys +  1.43 cusr  0.07 csys =  1.54 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comments on last patch

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 11 Katrin Fischer 2014-06-22 20:06:59 UTC
Created attachment 29149 [details] [review]
[PASSED QA] Bug 12416: the subroutine 'ok' is replaced by the subroutine 'is'

The use of the subroutine 'is' is prefered over the subroutine 'is'

To test: execute the commande prove t/db_dependent/Borrower_Debarments.t
To command has to print:
t/db_dependent/Borrower_Debarments.t .. ok
All tests successful.
Files=1, Tests=22,  1 wallclock secs ( 0.03 usr  0.01 sys +  1.42 cusr  0.08 csys =  1.54 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comments on last patch

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 12 Katrin Fischer 2014-06-22 20:07:10 UTC
Created attachment 29150 [details] [review]
[PASSED QA] Bug 12416: add new tests of DelUniqueDebarment

The subroutine DelUniqueDebarment was not enough tested

To test: execute the command prove t/db_dependent/Borrower_Debarments.t
The command has to print:
t/db_dependent/Borrower_Debarments.t .. ok
All tests successful.
Files=1, Tests=31,  1 wallclock secs ( 0.03 usr  0.01 sys +  1.44 cusr  0.08 csys =  1.56 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
All 31 test pass, no koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests pass.
Comment 13 Tomás Cohen Arazi 2014-06-22 23:36:58 UTC
Patches pushed to master.

Thanks Yohann!
Comment 14 Galen Charlton 2014-06-25 22:26:53 UTC
Pushed to 3.16.x for inclusion in 3.16.1