Created attachment 28840 [details] link to overdrive results When on your search results you can click the link to overdrive results, but then you can't get back to your catalog search results, the line that links to the results should be there on both pages.
Created attachment 28841 [details] no link back
*** Bug 11959 has been marked as a duplicate of this bug. ***
Created attachment 36841 [details] [review] Bug 12421 - no way to get back to search results from overdrive results When on your search results you can click the link to overdrive results, but then you can't get back to your catalog search results, the line that links to the results should be there on both pages. Test Plan: 1) Apply this patch 2) Enable Overdrive searching 3) Perform a search 4) View the overdrive results 5) Note the "Catalog search for '$q'" link in the breadcrumbs 6) Click the link 7) Note you return to the search results page
Created attachment 45805 [details] [review] Signoff
The html filter should be used for both lines I would say.
It looks like this was forgotten about for a long time - can some Overdrive user maybe check if it is still an issue?
Created attachment 153539 [details] [review] Bug 12421: no way to get back to search results from overdrive results When on your search results you can click the link to overdrive results, but then you can't get back to your catalog search results, the line that links to the results should be there on both pages. Test Plan: 1) Apply this patch 2) Enable Overdrive searching 3) Perform a search 4) View the overdrive results 5) Note the "Catalog search for '$q'" link in the breadcrumbs 6) Click the link 7) Note you return to the search results page Signed-off-by: Barry Cannon <bc@interleaf.ie>
I rebased this patch and added the missing filter while I was at it. I'm usually not crazy about controls which simply mimic the back button, but I like the improved clarity in the breadcrumbs so I think this is a good case for it.
So.. who can test Overdrive? We might want to nudge some people here :)
Created attachment 154078 [details] [review] Bug 12421: no way to get back to search results from overdrive results When on your search results you can click the link to overdrive results, but then you can't get back to your catalog search results, the line that links to the results should be there on both pages. Test Plan: 1) Apply this patch 2) Enable Overdrive searching 3) Perform a search 4) View the overdrive results 5) Note the "Catalog search for '$q'" link in the breadcrumbs 6) Click the link 7) Note you return to the search results page Signed-off-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Easy enhancement, I choose to backport to stable Pushed to 23.05.x for 23.05.04
Enhancement, not backporting to 22.11.x Nice work everyone!