Bug 12421 - No way to get back to search results from overdrive results
Summary: No way to get back to search results from overdrive results
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Barry Cannon
QA Contact: Testopia
URL:
Keywords:
: 11959 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-06-13 14:30 UTC by Nicole C. Engard
Modified: 2023-08-31 10:08 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04


Attachments
link to overdrive results (52.00 KB, image/png)
2014-06-13 14:30 UTC, Nicole C. Engard
Details
no link back (54.96 KB, image/png)
2014-06-13 14:30 UTC, Nicole C. Engard
Details
Bug 12421 - no way to get back to search results from overdrive results (1.98 KB, patch)
2015-03-12 16:26 UTC, Kyle M Hall
Details | Diff | Splinter Review
Signoff (2.05 KB, patch)
2015-12-18 10:08 UTC, Barry Cannon
Details | Diff | Splinter Review
Bug 12421: no way to get back to search results from overdrive results (2.03 KB, patch)
2023-07-17 11:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12421: no way to get back to search results from overdrive results (2.08 KB, patch)
2023-07-30 20:45 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2014-06-13 14:30:42 UTC Comment hidden (obsolete)
Comment 1 Nicole C. Engard 2014-06-13 14:30:56 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2015-02-21 23:49:51 UTC
*** Bug 11959 has been marked as a duplicate of this bug. ***
Comment 3 Kyle M Hall 2015-03-12 16:26:53 UTC Comment hidden (obsolete)
Comment 4 Barry Cannon 2015-12-18 10:08:19 UTC
Created attachment 45805 [details] [review]
Signoff
Comment 5 Jonathan Druart 2015-12-28 10:15:46 UTC
The html filter should be used for both lines I would say.
Comment 6 Katrin Fischer 2023-07-15 19:55:14 UTC
It looks like this was forgotten about for a long time - can some Overdrive user maybe check if it is still an issue?
Comment 7 Owen Leonard 2023-07-17 11:14:50 UTC
Created attachment 153539 [details] [review]
Bug 12421: no way to get back to search results from overdrive results

When on your search results you can click the link to overdrive results,
but then you can't get back to your catalog search results, the
line that links to the results should be there on both pages.

Test Plan:
1) Apply this patch
2) Enable Overdrive searching
3) Perform a search
4) View the overdrive results
5) Note the "Catalog search for '$q'" link in the breadcrumbs
6) Click the link
7) Note you return to the search results page

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 8 Owen Leonard 2023-07-17 11:16:46 UTC
I rebased this patch and added the missing filter while I was at it. I'm usually not crazy about controls which simply mimic the back button, but I like the improved clarity in the breadcrumbs so I think this is a good case for it.
Comment 9 Katrin Fischer 2023-07-17 11:53:28 UTC
So.. who can test Overdrive? We might want to nudge some people here :)
Comment 10 Katrin Fischer 2023-07-30 20:45:07 UTC
Created attachment 154078 [details] [review]
Bug 12421: no way to get back to search results from overdrive results

When on your search results you can click the link to overdrive results,
but then you can't get back to your catalog search results, the
line that links to the results should be there on both pages.

Test Plan:
1) Apply this patch
2) Enable Overdrive searching
3) Perform a search
4) View the overdrive results
5) Note the "Catalog search for '$q'" link in the breadcrumbs
6) Click the link
7) Note you return to the search results page

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Tomás Cohen Arazi 2023-08-15 12:19:55 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 12 Fridolin Somers 2023-08-29 21:40:29 UTC
Easy enhancement, I choose to backport to stable

Pushed to 23.05.x for 23.05.04
Comment 13 Matt Blenkinsop 2023-08-31 10:08:32 UTC
Enhancement, not backporting to 22.11.x

Nice work everyone!