It's not possible to add a new patron category. There is a DB error in the logs but no feedback in staff, the newly created category just doesn't show up.
Created attachment 29053 [details] [review] Bug 12454: Fix for adding new patron categories To test: - Add a new patron category - After saving, the new patron category won't show up in the list - Apply patch - Try to add a new patron category again - It should now save correctly and show up in the list of patron categories.
Created attachment 29057 [details] [review] [SIGNED-OFF] Bug 12454: Can't add new patron categories To test: - Add a new patron category - After saving, the new patron category won't show up in the list - Apply patch - Try to add a new patron category again - It should now save correctly and show up in the list of patron categories. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 29090 [details] [review] Bug 12454: Can't add new patron categories To test: - Add a new patron category - After saving, the new patron category won't show up in the list - Apply patch - Try to add a new patron category again - It should now save correctly and show up in the list of patron categories. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Bug introduced by bug 6254.
Patch pushed to master. Thanks Katrina! Note: I'd like to see all this business logic be put in a lib in the Koha namespace we can have unit tests written for it. I'm sure this would belong to another bug report anyway.