Bug 12455 - The module C4/SMS.pm needs more unit tests
Summary: The module C4/SMS.pm needs more unit tests
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Yohann Dufour
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-20 07:24 UTC by Yohann Dufour
Modified: 2015-06-04 23:30 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 12455: adding unit tests for the module C4/SMS.pm (1.92 KB, patch)
2014-06-20 08:45 UTC, Yohann Dufour 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12455: adding unit tests for the module C4/SMS.pm (2.12 KB, patch)
2014-06-23 00:38 UTC, Bernardo Gonzalez Kriegel 		Details | Diff | Splinter Review
[PASSED QA] Bug 12455: adding unit tests for the module C4/SMS.pm (2.18 KB, patch)
2014-06-24 04:26 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 12455: (QA followup) license text missing (1.27 KB, patch)
2014-06-30 15:29 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yohann Dufour 2014-06-20 07:24:06 UTC 
The routines of the module C4/SMS.pm are not tested.
Comment 1 Yohann Dufour 2014-06-20 08:45:57 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-06-23 00:38:37 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-06-24 04:26:31 UTC 
Created attachment 29184 [details] [review]
[PASSED QA] Bug 12455: adding unit tests for the module C4/SMS.pm

The module C4/SMS.pm was not tested

Test plan:
1/ Execute the command : prove t/SMS.t
2/ The result has to be a success without error or warning :
t/SMS.t .. ok
All tests successful.
Files=1, Tests=7,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.17 cusr  0.02 csys =  0.23 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Replace stub test, all test pass.
Removed "use strict/warnings", no need for that with "use Modern::Perl"
No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2014-06-30 15:29:53 UTC 
Created attachment 29379 [details] [review]
Bug 12455: (QA followup) license text missing

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Comment 5 Tomás Cohen Arazi (tcohen) 2014-06-30 18:58:35 UTC 
Patch pushed to master.

Thanks Yohann!
Comment 6 Galen Charlton 2014-07-23 21:32:45 UTC 
Pushed to 3.16.x for inclusion in 3.16.2.