Bug 12458 - Holidays calendar has wrong colors for weekly and yearly repeatable
Summary: Holidays calendar has wrong colors for weekly and yearly repeatable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-20 12:51 UTC by Fridolin Somers
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12458 - Holidays calendar has wrong colors for weekly and yearly repeatable (3.00 KB, patch)
2014-06-20 12:58 UTC, Fridolin Somers
Details | Diff | Splinter Review
screenshot (168.43 KB, image/png)
2014-06-20 12:59 UTC, Fridolin Somers
Details
[SIGNED-OFF] Bug 12458 - Holidays calendar has wrong colors for weekly and yearly repeatable (3.27 KB, patch)
2014-06-20 18:58 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[PASSED QA] Bug 12458 - Holidays calendar has wrong colors for weekly and yearly repeatable (3.40 KB, patch)
2014-06-21 15:39 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2014-06-20 12:51:17 UTC
In Tools / Calendar, the colors in the calendar for weekly and yearly repeatable are different from the color of the "Key" legend.
Comment 1 Fridolin Somers 2014-06-20 12:58:33 UTC Comment hidden (obsolete)
Comment 2 Fridolin Somers 2014-06-20 12:59:11 UTC
Created attachment 29097 [details]
screenshot
Comment 3 Nicole C. Engard 2014-06-20 18:58:45 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-06-21 15:39:05 UTC
Created attachment 29130 [details] [review]
[PASSED QA] Bug 12458 - Holidays calendar has wrong colors for weekly and yearly repeatable

In Tools / Calendar, the colors in the calendar for weekly and yearly repeatable are different from the color of the "Key" legend.

This patch sets the colors used in the "Key" legend to the cells if calendar.

Test plan :
- Go to Tools/Calendar
- Add a weekly repeatable holiday
- Check its color in calendar is the same as the text "Holiday repeating weekly"
=> Without this patch, it's green instead of yellow
- Add a yearly repeatable holiday
- Check its color in calendar is the same as the text "Holiday repeating yearly"
=> Without this patch, it's yellow instead of orange
- Check the color of others holydays types are OK

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
I'd like to see today's date a clearly different color from the
weekly repeated holiday, because now they're close in color.
But this patch does exactly what it says and should so I'm signing
off.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Legend, headings and calendar colors now match.
No problems found.
Comment 5 Tomás Cohen Arazi 2014-06-21 19:45:25 UTC
Patch pushed to master.

Thanks Fridolin!
Comment 6 Fridolin Somers 2014-06-23 07:57:08 UTC
Whaou, a one-day-resolved bug ;)
Thanks everyone.
Comment 7 Galen Charlton 2014-06-24 15:38:58 UTC
Pushed to 3.16.x for inclusion in 3.16.1.
Comment 8 Fridolin Somers 2014-07-11 06:34:51 UTC
Pushed to 3.14.x, will be in 3.14.09
Comment 9 Kyle M Hall 2014-07-14 11:23:10 UTC
Pushed to 2.12.x, will be in 3.12.14