In Tools / Calendar, the colors in the calendar for weekly and yearly repeatable are different from the color of the "Key" legend.
Created attachment 29096 [details] [review] Bug 12458 - Holidays calendar has wrong colors for weekly and yearly repeatable In Tools / Calendar, the colors in the calendar for weekly and yearly repeatable are different from the color of the "Key" legend. This patch sets the colors used in the "Key" legend to the cells if calendar. Test plan : - Go to Tools/Calendar - Add a weekly repeatable holiday - Check its color in calendar is the same as the text "Holiday repeating weekly" => Without this patch, it's green instead of yellow - Add a yearly repeatable holiday - Check its color in calendar is the same as the text "Holiday repeating yearly" => Without this patch, it's yellow instead of orange - Check the color of others holydays types are OK
Created attachment 29097 [details] screenshot
Created attachment 29122 [details] [review] [SIGNED-OFF] Bug 12458 - Holidays calendar has wrong colors for weekly and yearly repeatable In Tools / Calendar, the colors in the calendar for weekly and yearly repeatable are different from the color of the "Key" legend. This patch sets the colors used in the "Key" legend to the cells if calendar. Test plan : - Go to Tools/Calendar - Add a weekly repeatable holiday - Check its color in calendar is the same as the text "Holiday repeating weekly" => Without this patch, it's green instead of yellow - Add a yearly repeatable holiday - Check its color in calendar is the same as the text "Holiday repeating yearly" => Without this patch, it's yellow instead of orange - Check the color of others holydays types are OK Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> I'd like to see today's date a clearly different color from the weekly repeated holiday, because now they're close in color. But this patch does exactly what it says and should so I'm signing off.
Created attachment 29130 [details] [review] [PASSED QA] Bug 12458 - Holidays calendar has wrong colors for weekly and yearly repeatable In Tools / Calendar, the colors in the calendar for weekly and yearly repeatable are different from the color of the "Key" legend. This patch sets the colors used in the "Key" legend to the cells if calendar. Test plan : - Go to Tools/Calendar - Add a weekly repeatable holiday - Check its color in calendar is the same as the text "Holiday repeating weekly" => Without this patch, it's green instead of yellow - Add a yearly repeatable holiday - Check its color in calendar is the same as the text "Holiday repeating yearly" => Without this patch, it's yellow instead of orange - Check the color of others holydays types are OK Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> I'd like to see today's date a clearly different color from the weekly repeated holiday, because now they're close in color. But this patch does exactly what it says and should so I'm signing off. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Legend, headings and calendar colors now match. No problems found.
Patch pushed to master. Thanks Fridolin!
Whaou, a one-day-resolved bug ;) Thanks everyone.
Pushed to 3.16.x for inclusion in 3.16.1.
Pushed to 3.14.x, will be in 3.14.09
Pushed to 2.12.x, will be in 3.12.14