Bug 12463 - Capitalization: Calendar tool, headings for different types of holidays
Summary: Capitalization: Calendar tool, headings for different types of holidays
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-21 15:36 UTC by Katrin Fischer
Modified: 2015-06-04 23:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12463 - Capitalization: Calendar tool, headings for different types of holidays (4.52 KB, patch)
2014-06-26 19:35 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 12463 - Capitalization: Calendar tool, headings for different types of holidays (4.63 KB, patch)
2014-06-27 13:22 UTC, Juhani Seppälä
Details | Diff | Splinter Review
[PASSED QA] Bug 12463 - Capitalization: Calendar tool, headings for different types of holidays (4.74 KB, patch)
2014-06-28 21:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-06-21 15:36:48 UTC
The headings on the tables with the different types of holidays and the heading on the page "Midway Calendar" are not following the capitalization rules.
Comment 1 Owen Leonard 2014-06-26 19:35:15 UTC Comment hidden (obsolete)
Comment 2 Juhani Seppälä 2014-06-27 13:22:09 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-06-28 21:35:36 UTC
Hi Juhani, thx for your sign off! 
Please remember to obsolete the original patch and set the status to 'needs sign-off', this way it will show up in the QA queue.
Comment 4 Katrin Fischer 2014-06-28 21:40:16 UTC
Created attachment 29352 [details] [review]
[PASSED QA] Bug 12463 - Capitalization: Calendar tool, headings for different types of holidays

There are several instances of incorrect capitalization in the Calendar
tool. This patch corrects them.

To test, apply the patch and go to Tools -> Calendar. Headings and
labels on the page should have correct capitalization.

Signed-off-by: Juhani Seppälä <jseppal@student.uef.fi>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
String changes in the template, no problems found.
Comment 5 Tomás Cohen Arazi 2014-07-02 19:02:15 UTC
Patch pushed to master.

Thanks Owen!