Bug 12465 - XSLT: Missing punctuation between 710$a and $b
Summary: XSLT: Missing punctuation between 710$a and $b
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Marcel de Rooy
URL:
Keywords:
: 10957 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-06-22 16:50 UTC by Katrin Fischer
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12465: Improve display of MARC21 710 in intranet and OPAC (4.05 KB, patch)
2014-06-22 17:36 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 12465: Improve display of MARC21 710 in intranet and OPAC (7.55 KB, patch)
2014-06-22 17:43 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12465: Improve display of MARC21 710 in intranet and OPAC (7.65 KB, patch)
2014-06-24 14:53 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12465: Improve display of MARC21 710 in intranet and OPAC (7.73 KB, patch)
2014-07-31 11:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-06-22 16:50:23 UTC
If you have a record with 710$a and $b, there is no space or punctuation between the fields in result list and detail page in OPAC and staff.
Comment 1 Katrin Fischer 2014-06-22 17:20:53 UTC
Example:

710 2  _aDeutschland
       _bBundestag
       _0(DE-588b)2116123-9
       _0(DE-576)193731266
       _9167
Comment 2 Katrin Fischer 2014-06-22 17:36:37 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-06-22 17:38:20 UTC
I am not sure if the attached patch fixes all cases and is ok as it is. 
Feedback very welcome!
Comment 4 Katrin Fischer 2014-06-22 17:43:46 UTC Comment hidden (obsolete)
Comment 5 Bernardo Gonzalez Kriegel 2014-06-24 14:53:25 UTC Comment hidden (obsolete)
Comment 6 Marcel de Rooy 2014-07-31 11:13:31 UTC
QA: Taking a look :)
Comment 7 Marcel de Rooy 2014-07-31 11:19:37 UTC
Created attachment 30391 [details] [review]
Bug 12465: Improve display of MARC21 710 in intranet and OPAC

Currently, 710$a and $b and $b will not display correctly.
This patch tries to improve the display adding the missing
space between both subfields.

Please test.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested, work as described on staff & opac for 710 detailed view.
Add space and punctuation.
No errors.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Marcel de Rooy 2014-07-31 11:24:57 UTC
QA Comment:
This patch improves the situation. Before $a and $b were glued together. Now we have a space in between everywhere for subfields a-b-c-d-n. 
I am not saying that we already reached the ideal solution. Just listing multiple $b's after $a with a space (and even more subfields possible) may probably not always be so clear. But I do not have "the better solution" at hand for this moment :)

Passed QA
Comment 9 Katrin Fischer 2014-07-31 11:26:19 UTC
Thx Marcel!
Comment 10 Tomás Cohen Arazi 2014-08-11 17:48:18 UTC
*** Bug 10957 has been marked as a duplicate of this bug. ***
Comment 11 Tomás Cohen Arazi 2014-08-11 17:51:22 UTC
I'm not sure about the result. I prefered my approach on the other bug. But this is a good start. Maybe later someone will make it even better.
Comment 12 Katrin Fischer 2014-08-11 18:12:05 UTC
I am sorry to have missed your bug - it wasn't intentional. :(

I kept it rather simple, because I was not totally sure either. Feedback from a cataloguing expert might be good :)
Comment 13 Tomás Cohen Arazi 2014-08-15 17:55:11 UTC
We agreed the patch needs to be revisited as it chomps any punctuation added by the cataloguer.
Comment 14 Katrin Fischer 2014-08-23 20:28:57 UTC
Hi Tomas,

for testing purposes I have cataloged the examples for 710 (from the German MARC21 translation, but they should be the same as on the LOC website, which is currently down for maintenance, these are the results:

Examples:

$aMinnesota.
$bConstitutional Convention
$d(1857 :
$gRepublican)

$aHerbert E. Budek Films and Slides (Firm)

$aUnited States.
$bArmy Map Service.
$tEastern United States 1:250,000.

$aNew Orleans Blue Serenaders.
$4prf

$aWGBH (Television station : Boston, Mass.)

$aHallmark Collection (Library of Congress)
$5DLC

$aBridgewater Library,
$eformer owner.
$5NjP

$a Algeria.
$t Treaties, etc.
$g England and Wales,
$d 1682 Apr. 20.

$a Catholic Church.
$t Mass, 33rd Sunday of ordinary time (Chant).
$f 1979.

$a Catholic Church.
$b Pope (1958-1963 : John XXIII).
$t Mater et magistra.
$l French.
$k Selections.
$f 1963.

$a United States.
$t Constitution.
$p 13th Amendment.

$a Ecuador.
$t Plan Nacional de Desarrollo, 1980-1984.
$n Parte 1,
$p Grandes objetivos nacionales.
$l English.

With the existing patch:
Minnesota. Constitutional Convention (1857; United States. Army Map Service; New Orleans Blue Serenaders [prf]; WGBH (Television station : Boston, Mass.); Hallmark Collection (Library of Congress); Bridgewater Library [former owner.]; Algeria. 1682 Apr. 20; Catholic Church; Catholic Church Pope ( 1958-1963 : John XXIII); United States; Ecuador. Parte 1.

Displaying 'as catalogued':
by Herbert E. Budek Films and Slides (Firm); Minnesota. Constitutional Convention (1857:; United States. Army Map Service.; New Orleans Blue Serenaders [prf]; WGBH (Television station : Boston, Mass.); Hallmark Collection (Library of Congress); Bridgewater Library, [former owner.]; Algeria. 1682 Apr. 20.; Catholic Church.; Catholic Church Pope ( 1958-1963 : John XXIII).; United States.; Ecuador. Parte 1,.

What we can see:
- we are not displaying all subfields currently that could be used
- the patch is just chopping off punctuation off the last subfield, which seems ok, since we are using semicolons between every 710.

Could you take another look?
Comment 15 Tomás Cohen Arazi 2014-08-24 16:32:30 UTC
Patch pushed to master.

Thanks Katrina!
Comment 16 Galen Charlton 2014-09-23 04:48:42 UTC
Pushed to 3.16.x for inclusion in 3.16.4.