Bug 12485 - Show OPAC search history when opacuserlogin is OFF
Summary: Show OPAC search history when opacuserlogin is OFF
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-26 08:34 UTC by Katrin Fischer
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12485 - Show OPAC search history when opacuserlogin is OFF (6.30 KB, patch)
2014-06-26 19:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12485 - Show OPAC search history when opacuserlogin is OFF (6.43 KB, patch)
2014-06-28 18:37 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 12485 - Show OPAC search history when opacuserlogin is OFF (6.56 KB, patch)
2014-06-28 20:21 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-06-26 08:34:15 UTC
Currently if a library doesn't have patrons and patron accounts, they can't offer the search history feature in OPAC. Only when you turn on opacuserlogin the search history link will be displayed. 

As Koha can store a search history for a not logged in user, the dependency on opacuserlogin could be removed.
Comment 1 Owen Leonard 2014-06-26 19:09:25 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-06-28 18:37:18 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-06-28 20:21:01 UTC
Created attachment 29351 [details] [review]
[PASSED QA] Bug 12485 - Show OPAC search history when opacuserlogin is OFF

In the boostrap OPAC the link to search history is missing if
opacuserlogin is turned off. OPAC search history should be available
whether or not users can log in. This patch removes this dependency.

To test, apply the patch and test with various combinations of
opacuserlogin and EnableOpacSearchHistory:

- opacuserlogin and EnableOpacSearchHistory both enabled
- opacuserlogin enabled and EnableOpacSearchHistory disabled
- opacuserlogin disabled and EnableOpacSearchHistory enabled

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.
Passes QA script and tests.
Comment 4 Chris Cormack 2014-07-02 20:45:07 UTC
Template only change, works as advertised, pushed as Module Maintainer