In future versions of Koha the OPAC prog template and its YUI dependencies will not exist. This leaves only the basketgroups page in the staff client which uses any YUI assets. For the sake of simplicity I think the yuipath preference should be removed and the path to local YUI assets be hard-coded in the basketgroups template.
Created attachment 29330 [details] [review] Bug 12494 - Remove yuipath system preference With the OPAC prog template going away, the only remaining use of the yuipath preference is on the basketgroups template. The yuipath preference should be removed and the local path hard-coded. This patch: - removes yuipath handling from C4/Templates.pm - removes the preference from sysprefs.sql - deletes the preference via updatedatabase.pl - removes the preference from the staff client preferences file - removes unused references to the YUI assets from the help file header include - adds the local YUI asset path to acqui/basketgroup.tt To test, apply the patch and run the database update. View some online help pages and confirm that they function correctly. View the basketgroups page (Acquisition -> Vendor -> Basket groups), edit a basket group, and confirm that basket drag and drop operations work correctly.
Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com>
Created attachment 29391 [details] [review] Bug 12494 - Remove yuipath system preference With the OPAC prog template going away, the only remaining use of the yuipath preference is on the basketgroups template. The yuipath preference should be removed and the local path hard-coded. This patch: - removes yuipath handling from C4/Templates.pm - removes the preference from sysprefs.sql - deletes the preference via updatedatabase.pl - removes the preference from the staff client preferences file - removes unused references to the YUI assets from the help file header include - adds the local YUI asset path to acqui/basketgroup.tt To test, apply the patch and run the database update. View some online help pages and confirm that they function correctly. View the basketgroups page (Acquisition -> Vendor -> Basket groups), edit a basket group, and confirm that basket drag and drop operations work correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Created attachment 29514 [details] [review] [PASSED QA] Bug 12494 - Remove yuipath system preference With the OPAC prog template going away, the only remaining use of the yuipath preference is on the basketgroups template. The yuipath preference should be removed and the local path hard-coded. This patch: - removes yuipath handling from C4/Templates.pm - removes the preference from sysprefs.sql - deletes the preference via updatedatabase.pl - removes the preference from the staff client preferences file - removes unused references to the YUI assets from the help file header include - adds the local YUI asset path to acqui/basketgroup.tt To test, apply the patch and run the database update. View some online help pages and confirm that they function correctly. View the basketgroups page (Acquisition -> Vendor -> Basket groups), edit a basket group, and confirm that basket drag and drop operations work correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Online help and basket group drag&drop functionality still work correctly.
In my opinion, this patch should not be pushed before bug 12233. It will break ccsr and prog themes.
Oh, what did I miss? I had tested a few pages in staff, are we still using yui in OPAC?
git grep yuipath returns: koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc:<script type="text/javascript" src="[% yuipath %]/utilities/utilities.js"></script> koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc:<script type="text/javascript" src="[% yuipath %]/container/container-min.js"></script> koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc:<script type="text/javascript" src="[% yuipath %]/menu/menu-min.js"></script> koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc:<script type="text/javascript" src="[% yuipath %]/utilities/utilities.js"></script> koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc:<script type="text/javascript" src="[% yuipath %]/container/container-min.js"></script> koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc:<script type="text/javascript" src="[% yuipath %]/menu/menu-min.js"></script> koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt:<script type="text/javascript" src="[% yuipath %]/utilities/utilities.js"></script> koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt:<script type="text/javascript" src="[% yuipath %]/container/container-min.js"></script> koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt:<script type="text/javascript" src="[% yuipath %]/menu/menu-min.js"></script>
I need to get better with grep - thx for catching this!
This patch doesn't touch the prog and ccsr templates because it is dependent on their removal.
Patch pushed to master. Thanks Owen!