Bug 12495 - Street number missing from hold alert on checkin page
Summary: Street number missing from hold alert on checkin page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Roberts
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-27 22:52 UTC by David Roberts
Modified: 2016-06-21 21:36 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (3.94 KB, patch)
2014-06-30 15:29 UTC, David Roberts
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12495 - Include streetnumber in hold alert address (4.65 KB, patch)
2014-06-30 16:36 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 12495 - Include streetnumber in hold alert address (4.76 KB, patch)
2014-07-06 18:29 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 12495 [QA Followup] - Re-work "Renew or return" button as well (1.23 KB, patch)
2015-01-02 16:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12495 [QA Followup] - Re-work "Renew or return" button as well (1.23 KB, patch)
2015-01-02 16:11 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12495 [QA Followup] - Re-word "Renew or return" button as well (1.23 KB, patch)
2015-01-02 16:12 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Roberts 2014-06-27 22:52:27 UTC
When an item with a hold is checked in, the "hold found" alert does not display the street number.
Comment 1 David Roberts 2014-06-30 15:29:28 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-06-30 15:53:37 UTC
Please don't forget to assign bugs to yourself if you are supplying a patch. If the patch is ready for testing the status of the bug should be changed to "needs signoff." A patch which is ready for testing should include a test plan in the commit message.
Comment 3 David Roberts 2014-06-30 15:59:12 UTC
To test this, place a hold on an item that is on-loan, having first made sure that the requesting user has a value in the street number field of his address. Check the item in, and an alert should appear giving the name and address of the requesting user. This address should include the contents of the street number address field.
Comment 4 David Roberts 2014-06-30 16:00:20 UTC
(In reply to Owen Leonard from comment #2)
> Please don't forget to assign bugs to yourself if you are supplying a patch.
> If the patch is ready for testing the status of the bug should be changed to
> "needs signoff." A patch which is ready for testing should include a test
> plan in the commit message.

Sorry - I'm new to this! :-) Hope everything is OK now.
Comment 5 Owen Leonard 2014-06-30 16:36:50 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2014-07-06 18:29:16 UTC
Created attachment 29526 [details] [review]
[PASSED QA] Bug 12495 - Include streetnumber in hold alert address

Steetnumber is not included in the addess in the hold alert add the
field to those displayed

To test this, place a hold on an item that is on-loan, having first made
sure that the requesting user has a value in the street number field of
his address. Check the item in, and an alert should appear giving the
name and address of the requesting user. This address should include the
contents of the street number address field.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I was able to confirm three of the four template changes for the
following cases:

- Item placed on hold for a patron at the current library, not waiting
- Item placed on hold for a patron at the current library, already
  waiting
- Item placed on hold for a patron at another library, not waiting

I don't know how to trigger the case [% IF ( diffbranch ) %].

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes QA script and tests.
Note: Maybe sample slip templates should also include street number?
Comment 7 Katrin Fischer 2014-07-06 18:31:03 UTC
Hi David, I believe this is your first patch - thanks and congratulations :)
Comment 8 Tomás Cohen Arazi 2014-07-07 14:01:27 UTC
Patch pushed to master.

Thanks, and congratulations David!

Note: a discussion on how to compose addresses with different naming schemas (a.k.a. 'localized') is in place, but belongs to another bug.
Comment 9 Kyle M Hall 2015-01-02 16:10:43 UTC Comment hidden (obsolete)
Comment 10 Kyle M Hall 2015-01-02 16:11:07 UTC Comment hidden (obsolete)
Comment 11 Kyle M Hall 2015-01-02 16:12:09 UTC Comment hidden (obsolete)