Bug 12499 - The module C4::Letters.t needs more unit tests
Summary: The module C4::Letters.t needs more unit tests
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Yohann Dufour
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-30 07:53 UTC by Yohann Dufour
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12499: adding units tests for C4::Letters (10.50 KB, patch)
2014-07-02 07:18 UTC, Yohann Dufour
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12499: adding units tests for C4::Letters (10.60 KB, patch)
2014-07-02 14:50 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12499: adding units tests for C4::Letters (10.65 KB, patch)
2014-07-06 17:24 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Yohann Dufour 2014-06-30 07:53:05 UTC
Some subroutines of the module C4::Letters.t are not tested.
Comment 1 Yohann Dufour 2014-07-02 07:18:09 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-07-02 14:50:52 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-07-06 17:24:37 UTC
Created attachment 29518 [details] [review]
[PASSED QA] Bug 12499: adding units tests for C4::Letters

The tests for the subroutines : GetMessageTransportType, EnqueueLetter, SendQueuedMessages, GetQueuedMessages, GetLetters, getletter, addalert, getalert, delalert and GetPreparedLetter of the module C4::Letters have been added.

Test plan:
1) Apply the patch
2) Execute the unit tests by launching :
prove t/db_dependent/Letters.t
3) The result has to be a success without error or warning :
t/db_dependent/Letters.t .. ok
All tests successful.
Files=1, Tests=45,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.44 cusr  0.08 csys =  1.57 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
All test pass, no errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2014-07-07 13:19:08 UTC
Patch pushed to master.

Thanks Yohann!