Bug 12511 - Novelist Select not using https in bootstrap
Summary: Novelist Select not using https in bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-01 15:28 UTC by Kyle M Hall
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12511 - Novelist Select not using https in bootstrap (1.79 KB, patch)
2014-07-01 15:30 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 12511 - Novelist Select not using https in bootstrap (1.91 KB, patch)
2014-07-06 18:43 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-07-01 15:28:30 UTC
In prog we have:
[% IF ( NovelistSelectProfile ) %]
<script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script>
[% END %]

but in bootstrap we have 
[% IF ( NovelistSelectProfile ) %]
<script type="text/javascript" src="http://imageserver.ebscohost.com/novelistselect/ns2init.js"></script>
[% END %]

Because bootstrap isn't using https, we get an error like this:
[blocked] The page at 'https://koha.mylibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=105315&query_desc=kw%2Cwrdl%3A%20home' was loaded over HTTPS, but ran insecure content from 'http://imageserver.ebscohost.com/novelistselect/ns2init.js': this content should also be loaded over HTTPS.
Comment 1 Kyle M Hall 2014-07-01 15:30:48 UTC Comment hidden (obsolete)
Comment 2 Chris Rohde 2014-07-01 23:27:25 UTC
We have NoveList Select, are running Bootstrap, on an https server.  The patch works on our server.
Comment 3 Katrin Fischer 2014-07-06 18:43:03 UTC
Created attachment 29528 [details] [review]
[PASSED QA] Bug 12511 - Novelist Select not using https in bootstrap

In prog we have:
[% IF ( NovelistSelectProfile ) %]
<script type="text/javascript"
src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script>
[% END %]

but in bootstrap we have
[% IF ( NovelistSelectProfile ) %]
<script type="text/javascript"
src="http://imageserver.ebscohost.com/novelistselect/ns2init.js"></script>
[% END %]

Because bootstrap isn't using https, we get an error like this:
[blocked] The page at
'https://koha.mylibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=105315&query_desc=kw%2Cwrdl%3A%20home'
was loaded over HTTPS, but ran insecure content from
'http://imageserver.ebscohost.com/novelistselect/ns2init.js': this
content should also be loaded over HTTPS.

Test plan would require having a subscription to Novelist Select.
I think this is trivial enough to go without.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Very small change, trusting Kyle and the sign-off here.
Comment 4 Tomás Cohen Arazi 2014-07-07 14:01:44 UTC
Patch pushed to master.

Thanks Kyle!
Comment 5 Galen Charlton 2014-07-23 21:34:56 UTC
Pushed to 3.16.x for inclusion in 3.16.2.