Bug 12512 - PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference
Summary: PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 12233
Blocks: 11346
  Show dependency tree / graph
 
Reported: 2014-07-01 16:08 UTC by Owen Leonard
Modified: 2015-06-04 23:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 12512 - PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference (4.43 KB, patch)
2014-07-01 16:32 UTC, Owen Leonard 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12512 - PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference (4.50 KB, patch)
2014-07-03 13:09 UTC, Bernardo Gonzalez Kriegel 		Details | Diff | Splinter Review
[PASSED QA] Bug 12512 - PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference (4.55 KB, patch)
2014-07-03 14:27 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-07-01 16:08:21 UTC 
The Bootstrap theme doesn't have a binary distinction between "desktop" and "mobile," so the OpacShowFiltersPulldownMobile system preference doesn't make sense to have anymore. With CCSR deprecated the OpacShowFiltersPulldownMobile system preference can be removed.
Comment 1 Owen Leonard 2014-07-01 16:32:01 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-07-03 13:09:39 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall (khall) 2014-07-03 14:27:06 UTC 
Created attachment 29482 [details] [review]
[PASSED QA] Bug 12512 - PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference

CCSR having been deprecated there is no longer a use for the
OpacShowFiltersPulldownMobile system preference. This patch removes
it.

To test, apply the patch and run updatedatabase. Check that the
preference can no longer be found in system preferences.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Preference removed, no koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Chris Cormack 2014-08-07 02:03:31 UTC 
Pushed to MM_OPAC/theme_dep


Note please do not merge this branch yet, until I have all the prog/ccsr patches on there, and have them all working happily together
Comment 5 Chris Cormack 2014-08-07 02:55:32 UTC 
This is quite safe, have moved this straight to master, will apply the others on only on the MM_OPAC/them_dep branch